Skip to content

Fix IOStats for Nimble #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
helfman wants to merge 1 commit into from
Closed

Fix IOStats for Nimble #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dwio/nimble/common/tests/TestUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,14 @@ class InMemoryTrackableReadFile final : public velox::ReadFile {
NIMBLE_NOT_SUPPORTED("Not used by Nimble");
}

void preadv(
uint64_t preadv(
folly::Range<const velox::common::Region*> regions,
folly::Range<folly::IOBuf*> iobufs) const override {
VELOX_CHECK_EQ(regions.size(), iobufs.size());
uint64_t length = 0;
for (size_t i = 0; i < regions.size(); ++i) {
const auto& region = regions[i];
length += region.length;
auto& output = iobufs[i];
if (shouldProduceChainedBuffers_) {
chunks_.wlock()->push_back({region.offset, region.length});
Expand All @@ -332,6 +334,8 @@ class InMemoryTrackableReadFile final : public velox::ReadFile {
output.append(region.length);
}
}

return length;
}

uint64_t size() const final {
Expand Down
11 changes: 1 addition & 10 deletions dwio/nimble/tablet/TabletReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@

namespace facebook::nimble {

DEFINE_bool(
nimble_disable_coalesce,
false,
"Disable read coalescing in Nimble reader.");

DEFINE_uint64(
nimble_coalesce_max_distance,
1024 * 1024 * 1.25,
"Maximum read coalescing distance in Nimble reader. And gap smaller than this value will be coalesced.");

// Here's the layout of the tablet:
//
// stripe 1 streams
Expand All @@ -59,6 +49,7 @@ DEFINE_uint64(
// 2 bytes major version + 2 bytes minor version +
// 4 bytes magic number.
namespace {

template <typename T>
const T* asFlatBuffersRoot(std::string_view content) {
return flatbuffers::GetRoot<T>(content.data());
Expand Down