Revert GlobalConfig to use gflags again#147
Closed
kgpai wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Revert GlobalConfig to use gflags again#147kgpai wants to merge 1 commit intofacebookincubator:mainfrom
kgpai wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70463150 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70463150 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Mar 2, 2025
Summary: X-link: facebookincubator/nimble#147 Reverts the use of GlobalConfig and switches back to using gflags. Unfortunately using globalConfig requires us to call translateFlagsToGlobalConfig immediately after ParseCommandLineFlags to initialize it right. Because other libraries also use velox , transitively there are many such places. Thus reverting this change till we figure out a better mechanism to remove gflags dependencies. Differential Revision: D70463150
Summary: X-link: facebookincubator/velox#12503 Reverts the use of GlobalConfig and switches back to using gflags. Unfortunately using globalConfig requires us to call translateFlagsToGlobalConfig immediately after ParseCommandLineFlags to initialize it right. Because other libraries also use velox , transitively there are many such places. Thus reverting this change till we figure out a better mechanism to remove gflags dependencies. Reviewed By: amitkdutta Differential Revision: D70463150
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70463150 |
Contributor
|
This pull request has been merged in 5bc208f. |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Mar 3, 2025
Summary: Pull Request resolved: #12503 X-link: facebookincubator/nimble#147 Reverts the use of GlobalConfig and switches back to using gflags. Unfortunately using globalConfig requires us to call translateFlagsToGlobalConfig immediately after ParseCommandLineFlags to initialize it right. Because other libraries also use velox , transitively there are many such places. Thus reverting this change till we figure out a better mechanism to remove gflags dependencies. Reviewed By: amitkdutta Differential Revision: D70463150 fbshipit-source-id: 7bbd33818666c1f4235ef2e33496fa5cd8cf6a6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Reverts the use of GlobalConfig and switches back to using gflags. Unfortunately using globalConfig requires us to call translateFlagsToGlobalConfig immediately after ParseCommandLineFlags to initialize it right. Because other libraries also use velox , transitively there are many such places. Thus reverting this change till we figure out a better mechanism to remove gflags dependencies.
Differential Revision: D70463150