Fix build with gcc #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@dreiss has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kDescriptor needs full qualification because gcc complained of a mismatched declaration and definition otherwise. SimpleFixedString got FBJNI_HAS_FEATURE because `#if defined(foo) && foo(bar)` is a preprocessor syntax error with gcc.
There was a problem hiding this comment.
@dreiss has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Dec 27, 2019
Summary: kDescriptor needs full qualification because gcc complained of a mismatched declaration and definition otherwise. SimpleFixedString conditions were reordered because `#if defined(foo) && foo(bar)` is a preprocessor syntax error with gcc. Pull Request resolved: facebookincubator/fbjni#27 Reviewed By: swolchok Differential Revision: D19233972 Pulled By: dreiss fbshipit-source-id: 60a2f1a9aa96ff4c35915e045481835041245c1f
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Dec 27, 2019
Summary: kDescriptor needs full qualification because gcc complained of a mismatched declaration and definition otherwise. SimpleFixedString conditions were reordered because `#if defined(foo) && foo(bar)` is a preprocessor syntax error with gcc. Pull Request resolved: facebookincubator/fbjni#27 Reviewed By: swolchok Differential Revision: D19233972 Pulled By: dreiss fbshipit-source-id: 60a2f1a9aa96ff4c35915e045481835041245c1f
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: kDescriptor needs full qualification because gcc complained of a mismatched declaration and definition otherwise. SimpleFixedString conditions were reordered because `#if defined(foo) && foo(bar)` is a preprocessor syntax error with gcc. Pull Request resolved: facebookincubator/fbjni#27 Reviewed By: swolchok Differential Revision: D19233972 Pulled By: dreiss fbshipit-source-id: 60a2f1a9aa96ff4c35915e045481835041245c1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kDescriptor needs full qualification because gcc complained of a
mismatched declaration and definition otherwise.
SimpleFixedString conditions were reordered because
#if defined(foo) && foo(bar)is a preprocessor syntax error with gcc.