Add pthread flags explicitly #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is needed for the PyTorch host build because it includes libgtest.a but doesn't provide any indication that it depends on pthreads. Should be totally safe on Android. Test Plan: CI. Not sure how to test the OSS Android build.
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@dreiss has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2019
Summary: This is needed for the PyTorch host build because it includes libgtest.a but doesn't provide any indication that it depends on pthreads. Should be totally safe on Android. Pull Request resolved: #16 Test Plan: CI. Not sure how to test the OSS Android build. Reviewed By: passy Differential Revision: D18056874 Pulled By: dreiss fbshipit-source-id: 5c8044a4285f991c46cbc9665c901e0f6e9a17d0
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Oct 22, 2019
Summary: This is needed for the PyTorch host build because it includes libgtest.a but doesn't provide any indication that it depends on pthreads. Should be totally safe on Android. Pull Request resolved: facebookincubator/fbjni#16 Test Plan: CI. Not sure how to test the OSS Android build. Reviewed By: passy Differential Revision: D18056874 Pulled By: dreiss fbshipit-source-id: 5c8044a4285f991c46cbc9665c901e0f6e9a17d0
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: This is needed for the PyTorch host build because it includes libgtest.a but doesn't provide any indication that it depends on pthreads. Should be totally safe on Android. Pull Request resolved: facebookincubator/fbjni#16 Test Plan: CI. Not sure how to test the OSS Android build. Reviewed By: passy Differential Revision: D18056874 Pulled By: dreiss fbshipit-source-id: 5c8044a4285f991c46cbc9665c901e0f6e9a17d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is needed for the PyTorch host build because it includes libgtest.a
but doesn't provide any indication that it depends on pthreads. Should
be totally safe on Android.
Test Plan:
CI. Not sure how to test the OSS Android build.