Add `PUBLIC_URL` env variable for advanced use (#937) #1504

Timer · 2017-02-08T22:54:14Z

Add support for PUBLIC_URL env variable
Remove unnecessary duplications
Simplify served path choice logic
~~Honor PUBLIC_URL in development~~
Add e2e tests

Enables serving static assets from specified host.

* Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

gaearon · 2017-02-08T23:02:33Z

Once we release this we should also add an "advanced configuration" to user guide documenting all environment variables we read. It should be targeted at advanced users so it can be relatively brief. We don't want everyone to do it.

Timer · 2017-02-08T23:13:55Z

I removed the suggestion to set the PUBLIC_URL env variable from the console logs as we want the feature to be "hidden".

gaearon · 2017-02-08T23:42:45Z

Sounds good, yea. We might want to do a proper optional config at a later stage anyway. Now that we know what should be in there.

gaearon · 2017-02-09T00:21:54Z

packages/react-scripts/config/utils/ensureSlash.js

@@ -0,0 +1,10 @@
+module.exports = function ensureSlash(path, needsSlash) {


I would like to move this into paths.js and instead export publicPath, publicUrl and whatever else is needed from it. This would be more explicit IMO.

So ideally Webpack configs shouldn't need ensureSlash because they should already have everything they need in the final form in the paths.

gaearon · 2017-02-09T00:23:43Z

Also let's make sure this doesn't break homepage: "." workaround people are using now.

gaearon · 2017-02-09T00:27:34Z

packages/react-scripts/config/webpack.config.dev.js

@@ -29,7 +30,7 @@ var publicPath = '/';
 // `publicUrl` is just like `publicPath`, but we will provide it to our app
 // as %PUBLIC_URL% in `index.html` and `process.env.PUBLIC_URL` in JavaScript.
 // Omit trailing slash as %PUBLIC_PATH%/xyz looks better than %PUBLIC_PATH%xyz.
-var publicUrl = '';
+var publicUrl = ensureSlash(paths.servedPath, false);


I expect that this might break HMR when PUBLIC_URL is specified. I think we might be assuming we're serving from the root somewhere either in start.js or in webpack hot client.

I'm not really sure why this was changed, but I know it still worked after. I didn't test HMR, though -- I'll remove it as I don't know why the homepage is relevant to the dev environment.

gaearon · 2017-02-09T11:20:25Z

I think supporting non-root URLs in development might be the right thing to do, but we should also make sure HMR works and that by default we open that URL in the browser (rather than localhost root).

The reason I think HMR might break is because I'm not sure where the server would be running. We need to make sure HMR endpoint would still be at the server root, and that HMR client would correctly find it.

Timer · 2017-02-09T13:14:05Z

The only side-effect of setting publicUrl in dev is for the DefinePlugin & (soon) InterpolateHtmlPlugin. It doesn't affect any other configuration (where it's being served, etc).

HMR and our page reloading still works.

Would you like to extend this feature to alter webpack's publicPath and allow the server to be started on a different host than localhost?

gaearon · 2017-02-09T13:29:46Z

The only side-effect of setting publicUrl in dev is for the DefinePlugin & (soon) InterpolateHtmlPlugin. It doesn't affect any other configuration (where it's being served, etc).

Oh okay, I misunderstood then. Yea, this seems fine for now.

gaearon · 2017-02-09T13:30:24Z

packages/react-scripts/config/paths.js

@@ -52,7 +88,10 @@ module.exports = {
  testsSetup: resolveApp('src/setupTests.js'),
  appNodeModules: resolveApp('node_modules'),
  ownNodeModules: resolveApp('node_modules'),
-  nodePaths: nodePaths
+  nodePaths: nodePaths,
+  publicUrl: getPublicUrl(resolveApp('package.json')),


It's fine to give these more verbose names if that would make it easier to understand what they represent. Right now it's not super obvious to me what the difference is.

I went ahead and just removed the third variable as it was unnecessary. publicUrl and servedPath seem straightforward to me (now that servedUrl is gone).

Would you prefer different names still?

gaearon · 2017-02-09T17:58:42Z

packages/react-scripts/config/paths.js

+  return url.parse(publicUrl).pathname;
+}
+
+var servedPath = getServedPath(resolveApp('package.json'));


It's a bit weird we're declaring it here but then later apply ensureSlash and export the result under the same name.

Went ahead and made this more in-line with the existing calls.
Also simplified the getServedPath logic.

gaearon · 2017-02-09T18:10:22Z

packages/react-scripts/config/webpack.config.dev.js

@@ -29,7 +29,7 @@ var publicPath = '/';
 // `publicUrl` is just like `publicPath`, but we will provide it to our app
 // as %PUBLIC_URL% in `index.html` and `process.env.PUBLIC_URL` in JavaScript.
 // Omit trailing slash as %PUBLIC_PATH%/xyz looks better than %PUBLIC_PATH%xyz.
-var publicUrl = '';
+var publicUrl = paths.servedPath.slice(0, -1);


What was the use case for supplying PUBLIC_URL in dev?

Was requested here #937 (comment)

Are you sure whether it requested just injecting ENV variable, or if it requested actually serving the app from /prefix in DEV?

After reviewing that request with more attention, it seems that this only solves part of the use case. I think that user would desire the application served from the /prefix.
Since that's the case, I think it's best we revert this behavior and ask for a discussion issue to be opened on the topic. I think adding that behavior is out of the scope of this PR.

Thoughts?

Yes, let's just keep it for prod for now.

Timer · 2017-02-09T20:25:40Z

I believe this is good to go, any last comments?

gaearon · 2017-02-09T20:45:15Z

Looks good, have you manually verified these use cases still work as expected in dev and prod?

No homepage or PUBLIC_URL
Homepage, no PUBLIC_URL
PUBLIC_URL, no homepage
Homepage and PUBLIC_URL

(I would presume PUBLIC_URL always overrides homepage.)

Timer · 2017-02-10T01:37:53Z

I tested these cases and just tested them again to double check. The old behavior still rules unless PUBLIC_URL is defined. When it is defined, it works as expected.

Also, some of these cases are covered by our tests. I think it would be worthwhile to cover the rest.

…ok#1504) * Add `PUBLIC_URL` env variable for advanced use (facebook#937) * Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

danriti · 2017-02-16T21:10:56Z

Hey @Timer thanks for this PR! I had a quick question about the following item in the description:

Honor PUBLIC_URL in development

Is this environment variable usable in development with version 0.9?

i.e. PUBLIC_URL=http://localhost/lol npm start

Or are we still limited to only using it with npm run build?

Timer · 2017-02-16T21:49:18Z

Hi @danriti!
The original scope of this PR included honoring PUBLIC_URL in development, but during the polishing phase we decided to remove it. Sorry! I've crossed it out in the OP.

Right now you can only use the environment variable with npm run build.
If you could provide us with a compelling use-case, we'd be more than happy to reconsider.

Also, the function of this environment parameter is explained here. Please let me know if this is unclear so that we can make the documentation better.

ggerrietts · 2017-02-16T22:25:07Z

We (@danriti and I) have a maybe specialized use case. We have two applications built with create-react-app that work in concert. One provides a common set of functionality that is shared with another business unit. This set of functionality includes your standard user CRUD and login. The other application is more domain specific. We expect to mount the user CRUD/login app underneath the /account route, while all other routes will point to our domain-specific application. All this stuff gets stood up inside docker containers etc etc.

During development, we have been running the React app from inside a Node container using create-react-app's scaffolding; we proxy to the API servers, and we have an nginx that does the routing. We expect to use load balancers in place of nginx in production, and CDNs in place of the Node containers.

Just today, we came to the conclusion that to support all the above requirements, we had to eject. We'd previously been deferring the "mount under /account" requirement. @danriti found this PR and was very excited; neither of us really wanted to eject. But I think that's what we gotta do. :)

Timer · 2017-02-16T23:34:12Z

That sounds like a fairly advanced use case, but what's the true need for mounting under /account during development?

Unless there's a need I don't fully understand, couldn't you use rewrite rules in nginx to handle the routing between the applications?

e.g.
App A -> port 3000
App B (/account) -> port 4000

rewrite :::3000/account -> :::4000
rewrite not :::4000/account -> :::3000

ggerrietts · 2017-02-17T14:00:15Z

The webpack app still wants to serve its assets under /.

To elaborate a little more, both apps will serve css from /, so either nginx needs to be able to differentiate and route per-file, or the webpack app in the /account app needs to serve those links at /account.

The answer is really either "don't use the webpack app and lose the HMR and autolinting in the development environment" or "eject and hand-tune the webpack config."

gaearon · 2017-02-17T14:22:34Z

Can you file a new issue and describe both the use case and the proposed solution there?
We can then decide how to move forward.

ggerrietts · 2017-02-17T14:27:14Z

Certainly. I'll try to write up something cogent before the day is out.

danriti · 2017-02-17T16:56:16Z

Adding the new issue link here simply to create links between the two 👍

#1582

…ok#1504) * Add `PUBLIC_URL` env variable for advanced use (facebook#937) * Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

@gaearon

* Heroku Deployment: Adds a note on how to resolve "File/Module Not Found Errors" (facebook#1260) * Adds note on how to resolve file or directory not found errors for heroku deployments * Style tweaks * Remove interactive shell check when opening browser on start (facebook#1264) Browser launch can still be suppressed using BROWSER=none * Only gitignore dirs in root, not deep (facebook#1267) * facebookgh-1269: Enabling nested folder paths for project name (facebook#1270) * facebookgh-1269: Enabling nested folder paths for project name * facebookgh-1269: Added "fs-extra" and removed "path-exists" * facebookgh-1269: Added e2e test cases to verify nested folder names * Remove path-exists from dependencies and replace it with fs.existsSync (facebook#1289) * Downgrading to compatible version of SockJS-Client (facebook#1274) * Updated react-scripts babel-jest && jest packages to 18.0.0 (facebook#1311) * Fixes duplicate "is" typo (facebook#1306) * fix readme: remove double 'we' (facebook#1312) * Use npm script hooks to avoid && in deploy script (facebook#1324) * Bump babel-loader version (facebook#1009) (facebook#1309) * Use yarnpkg alias to run Yarn (facebook#1365) There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering. * Use yarnpkg alias to run Yarn (facebook#1365) There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering. * Update changelog for 0.8.5 * Publish - [email protected] - [email protected] * Add missing import in react-dev-utils README.md (facebook#1369) * Change console.log for errors and warnings (facebook#1375) Array.forEach is passed the following parameters: currentValue The current element being processed in the array. index The index of the current element being processed in the array. array - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach console.log takes multiple arguments. We only want to print the first one, the actually message. * webpack-dev-server patch for 'still-ok' success status (facebook#1377) * Document Flow support (facebook#1384) * Document Flow support Projects created by Create React App use the `babel-preset-react` which includes Flow babel plugins which introduces new syntax. This is important for users to know as it causes what used to be syntax errors to be silently suppressed because they're valid type annotations in Flow. For example if a user accidentally has `[foo: 'bar']`, Babel will silently convert it to `[foo]`. * Make it a bit clearer * Use a more sophisticated template for end-to-end testing. (facebook#1187) * Use a more sophisticated template for end-to-end testing. * Not publish integration tests to npm * Use "commander" for cli argv handling * Handle different scripts version forms and exits without a name given * Prepare the commands for testing with a template * Fix dev "template" path * Add various features to test * Test various features separately * Test language features * Comment unused e2e.sh lines * Add "development" tests * Test environment variables * Test webpack plugins * Replace kitchensink README * Switch integration tests from jest to mocha * Use `fs-extra` * Use the correct folders * Do some cleanup * Print a better message for `--template` * Test `npm start` with and without https * Separate fast e2e testing from kitchensink testing * Hide `--internal-testing-template` (former `--template`) CLI option * replace two space syntax with <br> tag (facebook#1393) for consistency :) * Add causes of dev server not detecting changes (facebook#1422) * Add causes of dev server not detecting changes Add causes of `npm start` not detecting changes to Troubleshooting chapter of User Guide * Reworded slightly * Update README.md * Added links to tutorials for integrating cra with an api backend (facebook#1437) * Added Rails link to User Guide * docs: unify sections for rails and node backend integration * docs: fix faulty link and indentation * Added babel-runtime dependency to deduplicate dependencies when using yarn (facebook#1441) * Bump Jest version (facebook#1432) * Readme: Removes experimental from Jest snapshot (facebook#1453) Per final comment in facebook#372 `Snapshot rendering should actually be pretty stable / useable after React 15.4.1. See this post for more info.` * eject: Additionally remove `react-scripts` from dependencies (facebook#1458) ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present. * E2e jsdom fix (facebook#1470) * E2E: run tests when react is ready * Entangle e2e with callbacks * Remove unused e2e lines * - import expect and expect flow (facebook#1463) - code style * Reflect websocket proxy support on README (facebook#1013) (facebook#1483) * Reflect websocket proxy support on README * Add 'the' * Edit User Guide: Add ESLint config for VS Code users (facebook#1482) * Add ESLint config for VS Code users * Update VSC ESLint note to a better solution Update VSC ESLint note to a better solution as discussed in Pull Request * e2e: Reduce complexity of e2e and improve Jest coverage (facebook#1484) * UX: Explain why build is failing (facebook#1352) * Update comments for webpack loaders * Change "OS X" references to "macOS" (facebook#1511) Updated README.md to refer to the current rebranding. * corrected minor typo (facebook#1514) * clarifying the use of custom environment variables (facebook#1513) * clarifying the use of custom environment variables * Tweak * Add missing '\n' to the end of `package.json` file (facebook#1510) * Make all react app vars accessible in index.html (facebook#1440) * Make all vars accessiable in index.html * Fix wrong env provieded to DefinePlugin * Separate results from getClientEnvironment * The `string` should be object instead of string * Fix accessing wrong field * Changed variables naming to `raw` and `stringified` * Remove trailing commas * Add `PUBLIC_URL` env variable for advanced use (facebook#937) (facebook#1504) * Add `PUBLIC_URL` env variable for advanced use (facebook#937) * Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host. * Support relative asset paths for special case (facebook#1489) * Fix paths in CSS files when homepage is set to "./" In the production build, ExtractTextPlugin is used to generate a separate CSS file instead of injecting style through JavaScript. This plugin does not work well by default with nested output structure. To fix it, we give it a relative publicPath pointing to the build folder. * Add section in README to explain how to make builds deployable anywhere * Apply review requested change * Apply review changes 2 * readme: Add Advanced Configuration (facebook#1515) * Add Advanced Configuration section * Reference package.json instead * Add HOST, HTTPS, and CI * Switch wording from Amazon to a CDN * Add test runner comment * Add top-level README link * Simplify wording * Link to relevant docs * Link to apps * Add .env link * Simpler links * Add a CI flag note * Make build exit with error code when interrupted (facebook#1496) * Make build exit with error code when interrupted This addresses issue facebook#1493. Current behavior is that `npm run build` exits code 0 without creating a bundle when interrupted. This change makes the build script catch catchable interruptions and exit with the appropriate error code. * Better error messages for kill signals * Don't catch SIGINT Ctrl+C should exit silently, and already produces a non-zero exit code when sent to the console while `npm run build` is running. Exit code 0 is produced if SIGINT is sent directly to the `node build.js` process, but this is unlikely to happen. A SIGINT handler in `build.js` will also be triggered by Ctrl+C in the console, potentially producing unnecessary noise. * Style fix * No changes needed to build.js Problem is coming from the parent process, `react-scripts` * Make react-scripts script handle signals * Clarify context * Bump lerna * Add test cases for PUBLIC_URL and relative path (facebook#1519) * Add test cases to evaluate increased CI time * Add positive test cases * Add negative cases * Test default behavior * Exit on failure * Fix test * Add an annoying nit * Upgrade babel dependencies * Don't run CI on Node 0.10 (facebook#1521) * fix: add yarn gitignores (facebook#1507) * fix: add yarn gitignores to template * fix: add yarn gitignores to root * fix: add wildcard to npm-debug.log ignore * Upgrade dependencies (facebook#1522) * Upgrade dependencies * Re-add caret * Add CHANGELOG * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Make index.html interpolation instructions less clashing with env syntax * Add additional info about env variables * Massage 0.9.0 changelog * Add release cutters to changelog * Tweak indentation * Markdown whitespace fixes * Some changelog formatting * Suggest jest-enzyme for simplifying test matchers (facebook#994) * Suggest jest-enzyme for simplifying test matchers * Update README.md * Update README.md * Fix `test -e` with wildcard arguments. (facebook#1503) The `test` command fails with multiple arguments when given a unary operator such as '-e'. Add a function that can test one or more files by looping over all files. * Link to new Sass doc * Clarify Less/Sass support * Add a link to supported features * Add SASS support documentation facebook#1007 (facebook#1008) * Add SASS support documentation facebook#1007 * Change SASS section title to more generic label * Fix link in Table of Contents * Chain build-css with watch-css script, fix typos * Update Sass and Less naming style * Fix wording, remove offensive words * Slightly rewite * [documentation] how to disable autoprefix feature (facebook#1320) * added how to disable autoprefix feature in doc * Just link to the doc * Added link to Azure deployment tutorial (facebook#1338) * Correctly Command in README.md (facebook#1275) * change npm to yarn command * Keep npm primary option * reduxjs/redux#2004 List features beyond ES6 supported by create-react-app (facebook#1313) * reduxjs/redux#2004 List features beyond ES6 supported by create-react-app * Add more info * Update language support wording to ES2017 * Tweak syntax doc (facebook#1539) * Tweak syntax doc * Shorter version * Add useful link to react-scripts (facebook#1495) * Make node version check more robust in e2e.sh (facebook#1295) * Revert "Don't run CI on Node 0.10" (facebook#1547) * Revert "Don't run CI on Node 0.10" * Install after checking node version * Don't use travis install * update CSS preprocessor instructions (facebook#1543) * update CSS preprocessor instructions - Windows shell users should note that running two programs simultaneously is not supported. * fix the order of SASS build step - the suggested build step with integrated CSS preprocessing is wrong. The SASS preprocessor should run first, then the react-scripts build will pick the up-to-date final CSS * Add tweaks from PR discussion * Use Yarn latest in e2e (facebook#1534) * Use Yarn latest in e2e * Here too * And here plz * modified documentation for setting up jest-enzyme (facebook#1562) * Use https in link to Ignoring files at Github (facebook#1561) * add --recursive to sass watch script (facebook#1564) * Mention Windows support explicitly * Reorder * MacOS => macOS * Update README.md (facebook#1573) Update links to jest expect function. * Switch from Neo to Neutrino (facebook#1576) * Switch from Neo to Neutrino * Edited format to be consistent * fixes facebook#1584 PORT env variable not always an integer (facebook#1585) * babel-preset: remove babel-plugin-transform-es2015-parameters (facebook#1598) babel/babel#4851 is closed * Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR (facebook#1608) * Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR * Use br in react-scripts template README md * Use br in md for new line breaks * Update troubleshooting HMR to allow for VMs running Windows * Fix up the instructions * Allow --scripts-version to be a git url (facebook#1570) * Install react, react-dom, and react-scripts at the same time (facebook#1253) * Install react and react-dom along with react-scripts - Install react, react-dom and react-script in a same time - Move react-scripts to devDependencies. * Check if react, react-dom has been already installed - To backward compatibility with old CRA’s cli - In case old CRA doesn’t install react, react-don along with react-scripts * Use packageName to find script dependency - use packageName to find dependency - fix pathExists.sync * Check dependencies.react in package.json instead of actual files * Process exit when dependencies not found - Show error and exit when dependencies not found. - Log install show custom package name * Remove template string * Install dependencies if template is preseted * Remove dangling comma Resolves facebook#1239 * add a comment about NODE_ENV value set to 'production' during build step (facebook#1625) * add a comment about NODE_ENV value set to 'production' during build step facebook#790 (comment) * Move words around * Update flow configuration documentation (facebook#1518) * Update flow configuration documentation The documentation was missing creating the .flowconfig file * Update flow configuration documentation Adding in suggested changes * Wording * Wording * Add note about when to import bootstrap CSS. (facebook#1618) * Add note about when to import bootstrap CSS. * Tweak * Document Sass imports * Fix workflow if react-scripts package is linked via npm-link (facebook#1356) * add npm-link support * - remove extra veriable - simplify condition * update code after review: - remove utils/isReactScriptsLinked - add appPath and ownPath to paths.js (but only for "before eject" export case) * update code after review: - remove utils/isReactScriptsLinked - add appPath and ownPath to paths.js (but only for "before eject" export case) * update code after review: - remove utils/isReactScriptsLinked - add appPath and ownPath to paths.js (but only for "before eject" export case) - remove "if" block for fs.removeSync(ownPath) at ejec.tjs * change ownPath value * Document debugging in the browser. (facebook#1540) * Document debugging in the browser. * Styling * Link to "Debugging in the Editor" * Adding link to “Customizing” create-react-app (facebook#1121) Add documentation for customizing Bootstrap theme * Update index.js (facebook#1603) To avoid file conflict issue with IJ static web projects * Remove .bin files defined at react-scripts/package.json after eject (facebook#1567) * remove bin files after eject defined at package.json * add swallowing try/catch * Bump `recursive-readdir`. (facebook#1560) * Added a how-to on react-snapshot (facebook#1577) * Added a how-to on react-snapshot Added a section with a short description and link to a tutorial on generating static html pages with react-snapshot, and also linked to it from the section on managing the page title. * Updated link title for react-snapshot overview * Explained pre-rendering in a more generic way * Added link to top level README.md, and removed specifics from overview * Updated html -> HTML * Updated quotes and apostrophes * html -> HTML * Fix link * NPM version check for tip (facebook#1193) * Implemented a version check of npm to give a soft tip during the install procedure and fixed gitignore * Moved NPM check to method, it is only executed when you use NPM and the version is < 3. * Minor formatting tweaks * Simplify the code * Remove unnecessary change * Enable eslint caching in development (facebook#1578) * Enable eslint caching in development POC for facebook#740. Haven't found any problem, build times improved about 1s on my project and machine. * Bump eslint-loader to 1.6.3 * move @remove-on-eject block to persist cache config on eject * Use real build path name in build output (facebook#1478) Use the configured appBuild value in paths.js instead of hard-coding it to 'build'. This is helpful for the ejected case where the appBuild path is changed to another folder name. * adding a note on how to resolve "Could not find a required file." dep… (facebook#1391) * adding a note on how to resolve "Could not find a required file." deployment errors because of deleted or ignored files * Tweak * Unrelated style nits * Use posix paths for Jest config during eject (facebook#1635) Resolves facebook#1417 and facebook#1498. * Setting a dynamic port value for the pushstate-server URL text (facebook#1628) * Setting a dynamic port value for the pushstate-server URL text after a build is completed * Fixing merge conflict * Fix up broken line * Gracefully handle initial installation error (facebook#1512) * Gracefully handle initial installation error * Print out message when problem occurs * Delete project folder on errors * Fix directory deleting message Resolves facebook#1505 * Add changelog for 0.9.1 * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Update changelog * Fix npm test on Windows (facebook#1647) * Add 0.9.2 changelog * 0.9.2 * Add a note about known issue * Merge changelogs * Format differently * Set Chrome userDataDir to be under .vscode folder (facebook#1657) * Fix e2e when used with cold cache (facebook#1667) Resolves facebook#1666 * Fix e2e-simple (cont.) * Add appveyor.yml (facebook#1648) * Add appveyor.yml * Execute mocha directly in e2e test * Replace e2e process substitution * Kill nohup node processes after e2e * Disable known failing Windows test * Only build master * fix react dependency versions during initial install (facebook#1669) * fix react dependency versions during initial install * add review remarks * Remove Windows 0.10 simple test * add project name validation (facebook#1662) * add project name validation * Tweak console output * fix project cleanup on windows (facebook#1675) * Revert "Enable eslint caching in development" (facebook#1665) * add X-FORWARDED headers for proxy requests (facebook#1677) * Use offline cached version with yarn when it's possible (facebook#1423) * add --offline flag when we are using yarn and we are offline * Revert changes to init script We only run these commands for backward compat mode, in which we wouldn't receive the offline flag anyway * Don't pass isOnline to init script because it doesn't need it * Don't ping the Yarn registry if user doesn't have Yarn * Remove unused/wrong arguments * Move logs to error handler * Fix error handling * Report to the user that they're offline * Add 0.9.3 changelog (facebook#1683) * Add "migrating" section for 0.9.3 * Publish - [email protected] - [email protected] * False expression should not be in dependencies * Publish - [email protected] * appveyor: Build all branches * Suggest CRA 1.2.1 in changelog * Fixed missing flag in first preprocess command (facebook#1687) * Re-enable e2e-install directory test * Suggest to use .env for enabling polling mode (facebook#1698) * Diagnostic code (facebook#1695) * Adding diagnostic code as requested by @gaearon * Oops * Fix Jest tests for Cygwin * Improve reliability of port hint. (facebook#1696) * fixing things for people with the username `cwd` closes facebook#1694 * combine awk into a single command and add escaping * pin and bump lerna (facebook#1688) * Lerna 2.0.0-beta.38 expects packages entry * Add docs for apache's client side routing setting (facebook#1717) * Add docs for apache's client side routing setting * Tweak advice * Update now.sh deployment instructions. (facebook#1710) * Update now.sh deployment instructions. Incorporates changes announced at https://zeit.co/blog/now-static that streamline Now deployments from CRA projects. * Remove unintentional reference to deployed app. No emergency; just didn't intend to tout or send traffic to my prototype. * Add support for ignoreRestSiblings in no-unused-vars (facebook#1705) * updating eslint to 3.16.1 * add support for ignoreRestSiblings in eslint http://eslint.org/docs/rules/no-unused-vars#ignorerestsiblings * updating eslint to 3.16.1 in `react-scripts` * updating eslint * missing `^` * missing ^ * pinning main eslint and updating readme * Pin ESLint version * add double quotes to escape spaces in paths in e2e (facebook#1707) * add double quotes to escape spaces in path * Change $* to "$@" props to @n3tr * escape spaces in path for all e2e tests * Create appveyor.cleanup-cache.txt * Link Appveyor caches to appveyor.cleanup-cache.txt * Trigger AppVeyor cache cleanup * Fix hot reloading for WebpackDevServer after eject (facebook#1721) * Fix openBrowser() when BROWSER=open on macOS (facebook#1690) * Fix openBrowser() when BROWSER=open on macOS * Tweaks * Create empty package.json in e2e test (facebook#1401) (facebook#1402) * Create empty package.json in e2e test Create empty package.json in e2e test while installing packaged CLI to prevent installation issues. * Use "npm init" to initialize package.json instead of just writing an empty object into it. * Fix typo * Skip AppVeyor CI builds for Markdown changes (facebook#1723) * Skip CI builds for Markdown changes * I will never learn YML * Don't use ES6 in a file that should run on Node 4 (facebook#1724) * Bump jsx-a11y version (facebook#1542) * Bump jsx-a11y version * Update package dependecy for jsx-a11y * Bump version in react-scripts * Bump ESLint config to 0.6.0 manually * Fix Node 4 e2e tests (facebook#1730) * Lint internal scripts with eslint:recommended (facebook#1729) * Lint internal scripts with eslint:recommended * Warnings r bad * Fix ejecting from a scoped fork (facebook#1727) * Read script names from own bin instead of guessing This fixes ejecting from a fork that uses a different bin script name. * Fix ejecting for a scoped react-scripts fork We shouldn't hardcode react-scripts because fork name might differ. We also shouldn't rely on it being an immediate child because scoped packages are a level deeper. * Clarify that own* properties only exist before ejecting * Properly extract package name for installing tgz of scoped packages (facebook#1706) * Properly extract package name * Download package if need be ... * Oops * Add e2e test based on facebook#1537, but without specific filename * Pass packageName through promises A little bit more verbose but explicit and doesn't rely on shared mutable state. * Fix up directory name in test * Tweak failure message * Fix lint * extract generic build functions to react-dev-utils (facebook#1726) * Temp rename * Rename to change the case * extract generic build functions to react-dev-utils * tweak package json files and move removeFileNameHash * revert removeFileNameHash * use paths.appBuild in printFileSizes * use paths.appBuild in removeFileNameHash * change curried functions to regular functions * add fs-extra to react-dev-utils deps * move getDifferenceLabel inside printFileSizes * inline copyPublicFolder * combine printFileSizes and removeFileNameHash to fileSizeReporter * fix typo * Tweak APIs and fix issues * Fix heading * Remove missing file * Newline * Newline * Trailing space * Update FileSizeReporter.js * Update build.js * Bust AppVeoyr cache * Relax ESLint config peerDependency (facebook#1740) * Fix internal linting setup and add missing headers (facebook#1741) * Fix lint * Fix eject for linked react-scripts (facebook#1736) * fix eject for linked react-scripts * path.resolve => resolveApp * Add changelog for 0.9.4 * Publish - [email protected] - [email protected] - [email protected] - [email protected] * Adjust changelog wording * Switch to preset-env (facebook#1742) * Switch to preset-env Disables webpack modules by enabling babel modules to resolve facebook#1638 * Bump babel-core to match babel preset versions * Add uglify to targets * Display yarn instead of yarnpkg when creating a new app (facebook#1747) * Display yarn instead of yarnpkg * Refactored displayd commands * Removed testing directory * Add yarn steps for adding flow (facebook#1756) [skip ci] * Suggest `serve` for running in production (facebook#1760) * Suggest `serve` for serving the `build` directory * How to handle it with Node in prod (or other platforms) * Pretty newline added * Adjusted default port of static server * Remove `open` command from output * Removed constant assignment * Better explanation for not using having to use a static server * Cute newline added * Style nits * Remove 'guard-for-in' lint rule (facebook#1773) Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule? * Run CI on Node 7; Bump detect-port: 1.0.1 -> 1.1.0 (facebook#1776) (facebook#1783) * Run CI on Node 7 * Bump detect-port: 1.0.1 -> 1.1.0 * Run AppVeyor CI on Node 7 * Add 0.9.5 changelog (facebook#1784) * Add 0.9.5 changelog * Update CHANGELOG.md * Publish - [email protected] - [email protected] - [email protected] * docs(babel-preset): Update comment info about babel-preset-env. (facebook#1787) * Feature/readme-nomoretools (facebook#1799) * docs: replace TDLR with a meaningful heading * docs: insert section No additional build tools * Tweak wording * Suggest "yarn build" rather than "yarn run build" (facebook#1800) * Fix for issue facebook#1798: Suggested 'yarn build' versus 'yarn run build' * remove 'run' from 'yarn test' command as well * conditionally show 'run' if Yarn is not available * Tweak the wording * Allow creation of apps in empty mercurial repos (facebook#1811) * Allow creation of apps in empty mercurial repos * Adding .hgignore to list of validFiles for isSafeToCreateProjectIn check * Adding .hgcheck to list of validFiles for isSafeToCreateProjectIn check * Link to CRNA * Make Surge guide more focused * User Guide: Removed blockquote from code section, due to markdown conflict (facebook#1869) * Removed blockquote from code section * Fix the fix * Fix AppVeyor CI (facebook#1876) * Fix responsive behavior in iOS 9+ (facebook#1821) * Adding shrink-to-fit=no for proper responsive handling on Safari 9+ * Check internet connectivity with lookup instead of resolve (facebook#1863) Resolves facebook#1818 * Update `detect-port` (facebook#1861) Previous changes caused `detect-port` to pick random port on app startup. Update fixes this regression, `detect-port` pick next available port instead. * Fix importing linked packages (facebook#1884) Resolves facebook#1661 * Fix AppVeyor CI (facebook#1868) * Fix AppVeyor CI (facebook#1876) * Run AppVeyor on Visual Studio 2017 * Suggest Yarn in HTML template (facebook#1911) * Fix npm to yarn * yarn & npm * Update index.html * Switch ordering of suggestion We should suggest NPM first for new users. * Note that only [email protected] is compatible * Add sku to the list of alternatives (facebook#1962) * Update information in User Guide for Enzyme dependency (facebook#1982) * Ensure proxy url starts with `http://` or `https://` (facebook#1890) * Update ansi-html to fix facebook#1881 * Add linked modules test (0.9.x) (facebook#1912) * Add linked modules test * Keep fallback after eject * Add note about installing watchman (facebook#1950) * Add note about installing watchman * Update CONTRIBUTING.md * Start the dev server at the specified host Pass the host from environment variable as argument of the devServer's listen function instead of a field of options object. Set the default host to 0.0.0.0 instead of localhost. * Add folder structure docs for new contributors (facebook#1991) * Adding folder structure to help people navigate through project. It helps in resolving issues by providing brief description of each package and its purpose * Removing unnecessary packages from Folder structure heading * Update CONTRIBUTING.md * Relax label rules (facebook#1989) # Conflicts: # packages/eslint-config-react-app/index.js * Update doc server example to work from any directory (facebook#1988) * Node.js serving with absolute path It’s safer to use the absolute path of the directory that you want to serve, in case you run the express app from another directory. * Update README.md * Fix config discrepancies after merging from upstream v0.9.x * Minor fixes per feedback for upstream merging * Fix import from incorrect module * Release v7.0.0

Intregrisist · 2018-02-09T22:45:51Z

packages/react-scripts/config/paths.js

+function ensureSlash(path, needsSlash) {
+  var hasSlash = path.endsWith('/');
+  if (hasSlash && !needsSlash) {
+    return path.substr(path, path.length - 1);


Shouldn't this have been path.length?

Agreed that this is wrong, though I think that it should be 0, not path.length. This code works very accidentally, because Number(path) is NaN, which is converted to +0 by ToInteger in the definition of String.prototype.substr:

ECMAScript docs for substr

ECMAScript docs for ToInteger

(edited to include links to docs)

Fixed in #4424.

facebook-github-bot added the CLA Signed label Feb 8, 2017

Add PUBLIC_URL env variable for advanced use (facebook#937)

bb14761

* Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

Timer force-pushed the public-url branch from 1d0fd36 to bb14761 Compare February 8, 2017 22:56

gaearon reviewed Feb 9, 2017

View reviewed changes

Timer force-pushed the public-url branch 3 times, most recently from 36d90e0 to 857ac53 Compare February 9, 2017 01:48

Timer force-pushed the public-url branch from 857ac53 to f2f62f1 Compare February 9, 2017 13:10

gaearon reviewed Feb 9, 2017

View reviewed changes

Timer force-pushed the public-url branch 2 times, most recently from b6072d4 to ed7eade Compare February 9, 2017 17:30

gaearon reviewed Feb 9, 2017

View reviewed changes

Timer force-pushed the public-url branch from ed7eade to e350f6c Compare February 9, 2017 18:05

gaearon reviewed Feb 9, 2017

View reviewed changes

Polish PUBLIC_URL

fe81e4a

Timer force-pushed the public-url branch from e350f6c to fe81e4a Compare February 9, 2017 18:45

Timer merged commit 613b584 into facebook:master Feb 10, 2017

Timer deleted the public-url branch February 10, 2017 04:15

Timer mentioned this pull request Feb 10, 2017

Add support for PUBLIC_URL env variable #937

Closed

Timer mentioned this pull request Feb 10, 2017

Cannot serve built static assets from external CDN #936

Closed

gaearon added this to the 0.9.0 milestone Feb 10, 2017

Timer mentioned this pull request Feb 10, 2017

Add function parseHomepagePath with more logic #1280

Closed

Timer added the tag: new feature label Feb 11, 2017

kellyrmilligan mentioned this pull request Mar 31, 2017

serve bundles and app under homepage path #1887

Closed

Intregrisist reviewed Feb 9, 2018

View reviewed changes

lock bot locked and limited conversation to collaborators Jan 19, 2019

		@@ -0,0 +1,10 @@
		module.exports = function ensureSlash(path, needsSlash) {

Add PUBLIC_URL env variable for advanced use (#937) #1504

Add PUBLIC_URL env variable for advanced use (#937) #1504

Conversation

Timer commented Feb 8, 2017 • edited Loading

gaearon commented Feb 8, 2017

Timer commented Feb 8, 2017

gaearon commented Feb 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon commented Feb 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon commented Feb 9, 2017

Timer commented Feb 9, 2017

gaearon commented Feb 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Timer Feb 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Timer commented Feb 9, 2017

gaearon commented Feb 9, 2017 • edited by Timer Loading

Timer commented Feb 10, 2017 • edited Loading

danriti commented Feb 16, 2017 • edited Loading

Timer commented Feb 16, 2017

ggerrietts commented Feb 16, 2017

Timer commented Feb 16, 2017

ggerrietts commented Feb 17, 2017 • edited Loading

gaearon commented Feb 17, 2017

ggerrietts commented Feb 17, 2017

danriti commented Feb 17, 2017

Choose a reason for hiding this comment

wchargin May 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Add `PUBLIC_URL` env variable for advanced use (#937) #1504

Add `PUBLIC_URL` env variable for advanced use (#937) #1504

Timer commented Feb 8, 2017 •

edited

Loading

Timer Feb 9, 2017 •

edited

Loading

gaearon commented Feb 9, 2017 •

edited by Timer

Loading

Timer commented Feb 10, 2017 •

edited

Loading

danriti commented Feb 16, 2017 •

edited

Loading

ggerrietts commented Feb 17, 2017 •

edited

Loading

wchargin May 8, 2018 •

edited

Loading