Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function parseHomepagePath with more logic #1280

Closed
wants to merge 2 commits into from

Conversation

lucasavila00
Copy link

It checks if the string starts with @ and if does, if removes the @ and goes along without parsing the url.

Just a POC for the fix I suggested at #1279

It checks if the string starts with @ and if does, if removes the @ and goes along without parsing the url.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@EnoahNetzach
Copy link
Contributor

Is it related to #937?

@lucasavila00
Copy link
Author

lucasavila00 commented Dec 16, 2016

It is. I'm sorry but I didn't check the other PRs before submiting mine.
What I proposed might break legitimate use cases for the homepage package field, and I guess this will be a problem, but for simple use cases it does the job.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Feb 10, 2017

Thank you for your contribution, but this was superseded by #937 and #1504.
I look forward to more contributions from you in the future!

@Timer Timer closed this Feb 10, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants