Skip to content

[buffer reuse] fix the case of If + For + For #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manman-ren merged 2 commits into from
Jan 23, 2025
Merged

[buffer reuse] fix the case of If + For + For #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eade7c
[buffer reuse] fix the case of If + For + For
manman-ren Jan 22, 2025
9ca481a
nit
manman-ren Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/Dialect/TritonGPU/Transforms/WSCodePartition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,25 @@ Value getAccumLoopCountArg(scf::ForOp parentForOp) {
return tmpAccumLoopCount;
}

// Check to see if op is enclosed under ifOp.
static bool enclosing(scf::IfOp ifOp, Operation *op) {
auto pOp = op->getParentOfType<scf::IfOp>();
while (pOp) {
if (pOp == ifOp)
return true;
pOp = pOp->getParentOfType<scf::IfOp>();
}
return false;
}

// Check to see if there is no outer loop that is enclosed under ifOp.
static bool immediateEnclosing(scf::IfOp ifOp, Operation *subOp) {
auto pOp = subOp->getParentOfType<scf::ForOp>();
if (!pOp)
return true;
return !enclosing(ifOp, pOp.getOperation());
}

// Return true if the IfOp contains a ForOp that is in loopWithBufferReuse.
static bool
needAccumulatedLoopCnt(scf::IfOp ifOp,
Expand All @@ -132,7 +151,9 @@ needAccumulatedLoopCnt(scf::IfOp ifOp,
ifOp.walk<WalkOrder::PreOrder>([&](Operation *subOp) {
if (auto forOp = dyn_cast<scf::ForOp>(subOp))
for (auto tLoop : loopWithBufferReuse)
if (forOp.getOperation() == tLoop) {
// For the case of ifOp contains forOp, which contains subOp, no need to
// generate accumLoopCount for ifOp.
if (forOp.getOperation() == tLoop && immediateEnclosing(ifOp, tLoop)) {
needAccum = true;
break;
}
Expand Down