Support buffer reuse between ForOp and IfOp #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
htyu
reviewed
Jan 18, 2025
| SmallVector<scf::ForOp> orderedForOps; | ||
| SmallVector<Operation *> innerForOps; | ||
| // ForOp_A | ||
| // --> --> opsWithBufferReuse: ForOp_A |
There was a problem hiding this comment.
Is there any reuse in case 3?
| maxDepth > 0) { | ||
| // Persistent with a single inner loop. There is no sharing group, but | ||
| // we can use the logic to generate accumLoopCount for persistent case. | ||
| opsWithBufferReuse = opsAtMaxDepth; |
There was a problem hiding this comment.
Is this fixing a bug with variant inner loop trip count?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case of reuse between parallel IfOp and ForOp. Prior to this, we only allow buffer reuse across parallel ForOps.