[triton][beta] Fix budget-aware RLC crash on Blackwell by disabling Phase 5 (#1328)#1328
Closed
agron911 wants to merge 1 commit into
Closed
[triton][beta] Fix budget-aware RLC crash on Blackwell by disabling Phase 5 (#1328)#1328agron911 wants to merge 1 commit into
agron911 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@agron911 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101982801. |
meta-codesync
Bot
changed the title
agron911
force-pushed
the
export-D101982801
branch
from
71bac16 to
4878ac9
Compare
…hase 5 (facebookexperimental#1328) Summary: Disable budget-aware layout conversion elimination (Phase 5, smem_budget > 0) which crashes on Blackwell with `LLVM ERROR: Invalid out-dim size`. Root cause: `propagateSrcEncodingAndErase()` skips `scf::YieldOp` during type rewriting, leaving `scf::ForOp` results with stale encodings that corrupt LinearLayout dimensions. Also fix `GenerateSubtiledRegion.cpp` build break (`CGAEncodingAttr::getDefault` -> `get1CTALayout`). Reviewed By: sfzhu93 Differential Revision: D101982801
agron911
added a commit
to agron911/triton
that referenced
this pull request
Apr 24, 2026
…hase 5 (facebookexperimental#1328) Summary: Disable budget-aware layout conversion elimination (Phase 5, smem_budget > 0) which crashes on Blackwell with `LLVM ERROR: Invalid out-dim size`. Root cause: `propagateSrcEncodingAndErase()` skips `scf::YieldOp` during type rewriting, leaving `scf::ForOp` results with stale encodings that corrupt LinearLayout dimensions. Also fix `GenerateSubtiledRegion.cpp` build break (`CGAEncodingAttr::getDefault` -> `get1CTALayout`). Reviewed By: sfzhu93 Differential Revision: D101982801
agron911
force-pushed
the
export-D101982801
branch
from
4878ac9 to
a2d4454
Compare
agron911
added a commit
to agron911/triton
that referenced
this pull request
Apr 24, 2026
…hase 5 (facebookexperimental#1328) Summary: Pull Request resolved: facebookexperimental#1328 Disable budget-aware layout conversion elimination (Phase 5, smem_budget > 0) which crashes on Blackwell with `LLVM ERROR: Invalid out-dim size`. Root cause: `propagateSrcEncodingAndErase()` skips `scf::YieldOp` during type rewriting, leaving `scf::ForOp` results with stale encodings that corrupt LinearLayout dimensions. Also fix `GenerateSubtiledRegion.cpp` build break (`CGAEncodingAttr::getDefault` -> `get1CTALayout`). Reviewed By: sfzhu93 Differential Revision: D101982801
Contributor
|
This pull request has been merged in 60b64af. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Disable budget-aware layout conversion elimination (Phase 5, smem_budget > 0) which crashes on Blackwell with
LLVM ERROR: Invalid out-dim size. Root cause:propagateSrcEncodingAndErase()skipsscf::YieldOpduring type rewriting, leavingscf::ForOpresults with stale encodings that corrupt LinearLayout dimensions.Also fix
GenerateSubtiledRegion.cppbuild break (CGAEncodingAttr::getDefault->get1CTALayout).Reviewed By: sfzhu93
Differential Revision: D101982801