[triton][tlx] Map ttg.memdesc_index to tlx.local_view in TTGIR-to-TLX pass#1087
Open
[triton][tlx] Map ttg.memdesc_index to tlx.local_view in TTGIR-to-TLX pass#1087
Conversation
… pass Summary: The PrintTTGIRToTLX debug pass mapped `ttg.memdesc_index` to `tlx.memdesc_index`, but the correct TLX Python API name is `tlx.local_view`. This change aligns the emitted pseudocode with the actual TLX DSL, making the output closer to compilable TLX Python. This is the rebased remainder of D94700558 after [PR #983](#983) and [PR #1005](#1005) landed upstream. Those PRs already covered 6 of 7 changes (math op mappings, unsigned div/rem, NaN-propagating min/max, skipping gpu.barrier/convert_layout, convert layout transparent substitution via getValueName, TMA descriptor, constant deduplication--obsolete as #983 inlines constants at use sites). Rebased and authored with Claude. Note that while the original intent of D94700558 was to ensure that generated TLX from the TTGIR-to-TLX pass could compile, it did not achieve this yet. This PR is to just get us up to speed with the earlier WIP, and then we'll post additional fixes on top of this towards compilable TLX Python. Differential Revision: D96554961
meta-cla
Bot
added
the
CLA Signed
Contributor
Contributor
|
Thanks! Can you rebase this to autows/helion_release and upload the PR against autows/helion_release? We have been landing changes in autows/helion_release. |
tissue3
approved these changes
Mar 16, 2026
Contributor
tissue3
left a comment
tissue3
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The PrintTTGIRToTLX debug pass mapped
ttg.memdesc_indextotlx.memdesc_index, but the correct TLX Python API name istlx.local_view. This change aligns the emitted pseudocode with theactual TLX DSL, making the output closer to compilable TLX Python.
This is the rebased remainder of D94700558 after PR #983 and PR #1005
landed upstream. Those PRs already covered 6 of 7 changes (math op
mappings, unsigned div/rem, NaN-propagating min/max, skipping
gpu.barrier/convert_layout, convert layout transparent substitution via
getValueName, TMA descriptor, constant deduplication--obsolete as #983
inlines constants at use sites).
Rebased and authored with Claude.
Note that while the original intent of D94700558 was to ensure that generated
TLX from the TTGIR-to-TLX pass could compile, it did not achieve this yet. This
PR is to just get us up to speed with the earlier WIP, and then we'll post additional
fixes on top of this towards compilable TLX Python.
Differential Revision: D96554961