Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveIgnored: Set names for removed members to AddPadding::MemberPrefix #227

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

ajor
Copy link
Contributor

@ajor ajor commented Jul 11, 2023

This means they will be treated as padding, so CodeGen will not try to store any data for them.

This means they will be treated as padding, so CodeGen will not try to
store any data for them.
@ajor ajor force-pushed the removed-ignored-strict-mode branch from 28f47f1 to 4b6e530 Compare July 11, 2023 19:08
@ajor ajor changed the title RemoveIgnored: Name removed members AddPadding::MemberPrefix RemoveIgnored: Set names for removed members to AddPadding::MemberPrefix Jul 11, 2023
@ajor ajor marked this pull request as ready for review July 11, 2023 19:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #227 (4b6e530) into main (28b813c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files          90       90           
  Lines        9940     9940           
  Branches     1621     1621           
=======================================
  Hits         6591     6591           
  Misses       2498     2498           
  Partials      851      851           
Impacted Files Coverage Δ
test/test_remove_ignored.cpp 96.66% <ø> (ø)
oi/type_graph/RemoveIgnored.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajor ajor merged commit 3e8464e into facebookexperimental:main Jul 12, 2023
@ajor ajor deleted the removed-ignored-strict-mode branch July 12, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants