Add container without template params to container map #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsarwade
force-pushed
the
iobuf_fix
branch
3 times, most recently
from
cfa79f3 to
6087f47
Compare
Summary: If a container has 0 template params (e.g. IOBuf, IOBufQueue), it wasn't being added to containerTypeMap. This causes the deserialization to go wrong as TreeBuilder doesn't treat the types as container Test Plan: make test Reviewers: Subscribers: Tasks: Tags:
ajor
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If a container has 0 template params (e.g. IOBuf, IOBufQueue), it wasn't being added to containerTypeMap. This causes the deserialization to go wrong as TreeBuilder doesn't treat the types as container
Test Plan:
make test