AddChildren: Filter out false children #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajor
force-pushed
the
add-children-false-children
branch
from
ae9327e to
fe48500
Compare
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 65.31% 66.12% +0.81%
==========================================
Files 88 90 +2
Lines 9805 9849 +44
Branches 1609 1614 +5
==========================================
+ Hits 6404 6513 +109
+ Misses 2561 2488 -73
- Partials 840 848 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Use fully qualified names to determine if a class is really the child of our type. It may be that it is the child of another type with an identical name in another namespace.
ajor
force-pushed
the
add-children-false-children
branch
from
fe48500 to
2b03d3d
Compare
JakeHillion
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fully qualified names to determine if a class is really the child of our type. It may be that it is the child of another type with an identical name in another namespace.