create strict mode and enable it for tests #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeHillion
force-pushed
the
types-no-chase
branch
3 times, most recently
from
ab54b35 to
8dc18fd
Compare
JakeHillion
force-pushed
the
types-no-chase
branch
from
8dc18fd to
2befaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently tests do not fail if TreeBuilder did not completely consume the data segment and they definitely should. I think there's a solid argument to be made for making this fatal everywhere, but TreeBuilder V2 should remove this possibility anyway.
This PR creates a
strictmode that causes TreeBuilder to fatally error if it hasn't read all of the data segment and enables it for tests. This exposes a few issues under Type Graph/Typed Data Segment that will need fixing first.I was planning to hold off landing this until the bugs were fixed, but I think it makes more sense to blacklist the failing tests on the CI as we already do that with some. All tests are passing without
-ftype-graphor-ftyped-data-segment.Test plan