Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling improvements #169

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Conversation

ttreyer
Copy link
Contributor

@ttreyer ttreyer commented Jun 19, 2023

Summary

Fixes & QoL:

  • OIP: Fix TypeHierarchy deserialisation
  • OIP: Print 'this' as an argument for methods
  • OIP: Print location expressions of arguments
  • OITB: Add support for -f/-F feature flags

Also introduce the new tool oirp to read the content of OID's output RocksDB.

Test plan

No change to oid.

$ make test
...
99% tests passed, 1 tests failed out of 572

Total Test time (real) = 180.18 sec
...
The following tests FAILED:
        112 - integration_py (Timeout)

@ttreyer ttreyer force-pushed the ttreyer/oirp branch 2 times, most recently from 1a19925 to 4f554ce Compare June 19, 2023 14:05
Copy link
Contributor

@tyroguru tyroguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks Thierry.

We could probably do with a README file in the tools directory which details what the different tools are for preferably with examples of their usage.

@ttreyer ttreyer merged commit 3b752fd into facebookexperimental:main Jun 19, 2023
@ttreyer ttreyer deleted the ttreyer/oirp branch June 19, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants