Modify async stacks to keep track of a vector of ASRs #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jesswong
commented
Nov 7, 2024
ispeters
reviewed
Nov 7, 2024
ispeters
reviewed
Nov 7, 2024
jesswong
commented
Nov 12, 2024
|
Latest changes were tested internally |
ispeters
reviewed
Nov 12, 2024
ispeters
reviewed
Nov 12, 2024
ispeters
reviewed
Nov 13, 2024
rileyberton
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff updates async stack to keep track of the ASRs via a std::vector instead of a TLS key. This will allow us to keep track of the different ASRs for all threads, instead of just the crashing thread.
We also store the thread id to reduce ambiguity.