Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cancellation lifetime issue in type_erased_stream #565

Merged

Conversation

janondrusek
Copy link
Contributor

@janondrusek janondrusek commented Oct 4, 2023

fix cancellation lifetime issue in type_erased_stream (#547)

  • operation state / stop callback race for completion
  • ref counting mechanism similar to when_all

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
@janondrusek janondrusek force-pushed the type-erased-stream branch 2 times, most recently from c4de116 to a2026f3 Compare October 5, 2023 17:03
@janondrusek janondrusek changed the title Type erased stream fix lifetime issue in type_erased_stream Oct 5, 2023
@janondrusek janondrusek changed the title fix lifetime issue in type_erased_stream fix cancellation lifetime issue in type_erased_stream Oct 5, 2023
@janondrusek janondrusek marked this pull request as ready for review October 5, 2023 17:06
@janondrusek janondrusek requested a review from ispeters October 5, 2023 17:28
include/unifex/type_erased_stream.hpp Outdated Show resolved Hide resolved
include/unifex/type_erased_stream.hpp Show resolved Hide resolved
* operation state / stop callback race for completion
* ref counting mechanism similar to `when_all`
@janondrusek janondrusek merged commit 7dce9b9 into facebookexperimental:main Oct 5, 2023
@janondrusek janondrusek deleted the type-erased-stream branch October 5, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants