Remove deprecated stuff #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #539 made `unifex::sender<>` equivalent to `unifex::typed_sender<>`. This diff replaces all uses of `typed_sender<>` with `sender<>` and deletes `typed_sender<>`.
In the spirit of PR #539 and the previous diff, this diff banishes the concept of typed bulk senders by renaming `unifex::typed_bulk_sender<>` to `unifex::bulk_sender<>`. There's no such thing as an untyped bulk sender so there's no need to point out that a bulk sender is typed.
PR #538 deleted `unifex::via()`, which was an untyped _Sender_ algorithm, and changed all uses to use `unifex::typed_via()` instead. This diff recreates the `via.hpp` header; it now defines the "typed via" algorithm under the name `unifex::via()`. At the same time, this diff changes `unifex::typed_via` to be a deprecated alias for the `via` algorithm.
PR #538 deleted `unifex::via_stream()`, which was an untyped _Stream_ algorithm, and changed all uses to use `unifex::typed_via_stream()` instead. This diff recreates the `via_stream.hpp` header; it now defines the "typed via stream" algorithm under the name `unifex::via_stream()`. At the same time, this diff changes `unifex::typed_via_stream` to be a deprecated alias for the `via_stream` algorithm.
This diff deletes `operation_t`, `is_connectable_v`, and `is_connectable` from `sender_concepts.hpp`. All three things have been deprecated a long time and are not used in Unifex itself.
facebook-github-bot
added
the
CLA Signed
ispeters
commented
Jun 25, 2023
This diff reinstates `unifex::typed_sender<>` as a deprecated alias for `unifex::sender<>` and `unifex::typed_bulk_sender<>` as a deprecated alias for `unifex::bulk_sender<>`.
jesswong
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PRs #538 and #539 to remove the concept of "untyped" Senders and thus stop calling any Senders "typed" (they're all typed).
typed_sender<S>an alias forsender<S>so now I can replace all uses oftyped_sender<>withsender<>and deprecatetyped_sender<>.typed_bulk_sender<>tobulk_sender<>and deprecatedtyped_bulk_sender<>.typed_via()sovia()now means whattyped_via()meant and we retaintyped_via()as a deprecated alias forvia().typed_via_stream(),via_stream()now means whattyped_via_stream()meant and we retaintyped_via_stream()as a deprecated alias forvia_stream().sender_concepts.hppthat have been deprecated for a long time.