-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add debug_async_scope
#536
add debug_async_scope
#536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM but you left several TODOs behind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM but you left several TODOs behind.
fa2eb32
to
7dd94c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and some value category errors, but otherwise good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and some value category errors, but otherwise good.
`v1::debug_async_scope` and `v2::debug_async_scope` wrap the corresponding `async_scope`s and can be used as a direct replacement for debugging purposes. They keep track of nested operation states, allowing to identify the 'stuck' operations especially in case of a deadlock.
7dd94c8
to
9018582
Compare
v1::debug_async_scope
andv2::debug_async_scope
wrap thecorresponding
async_scope
s and can be used as a direct replacementfor debugging purposes. They keep track of nested operation states, allowing to identify the 'stuck' operations especially in case of a deadlock.