Skip to content

[URGENT] Implement Allocative for i128 and u128#16

Closed
0xAndoroid wants to merge 1 commit intofacebookexperimental:mainfrom
0xAndoroid:fix/impl-for-u128
Closed

[URGENT] Implement Allocative for i128 and u128#16
0xAndoroid wants to merge 1 commit intofacebookexperimental:mainfrom
0xAndoroid:fix/impl-for-u128

Conversation

@0xAndoroid
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Tretyakov <42178850+0xAndoroid@users.noreply.github.com>
@meta-cla
Copy link

meta-cla bot commented Aug 19, 2025

Hi @0xAndoroid!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2025
@meta-cla
Copy link

meta-cla bot commented Aug 19, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@0xAndoroid 0xAndoroid changed the title Implement Allocative for i128 and u128 [URGENT] Implement Allocative for i128 and u128 Aug 26, 2025
@0xAndoroid
Copy link
Contributor Author

Would appreciate a timely approval since it's blocking our development.

@facebook-github-bot
Copy link
Contributor

@scottcao has imported this pull request. If you are a Meta employee, you can view this in D81100961.

facebook-github-bot pushed a commit to facebook/starlark-rust that referenced this pull request Aug 27, 2025
Summary: Pull Request resolved: facebookexperimental/allocative#16

Reviewed By: Will-MingLun-Li

Differential Revision: D81100961

Pulled By: scottcao

fbshipit-source-id: 42729615043fc60ae1683217a14b5184654208dd
facebook-github-bot pushed a commit that referenced this pull request Aug 27, 2025
Summary: Pull Request resolved: #16

Reviewed By: Will-MingLun-Li

Differential Revision: D81100961

Pulled By: scottcao

fbshipit-source-id: 42729615043fc60ae1683217a14b5184654208dd
facebook-github-bot pushed a commit to facebook/buck2 that referenced this pull request Aug 27, 2025
Summary: Pull Request resolved: facebookexperimental/allocative#16

Reviewed By: Will-MingLun-Li

Differential Revision: D81100961

Pulled By: scottcao

fbshipit-source-id: 42729615043fc60ae1683217a14b5184654208dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants