Skip to content

[cleanup] cleanup loggers for console/notebook #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2024
Merged

[cleanup] cleanup loggers for console/notebook #1181

merged 4 commits into from
Dec 6, 2024

Conversation

@alxlyj
Copy link
Contributor

@alxlyj alxlyj commented Dec 6, 2024

Project Robyn

Summary

  • As titled, we are cleaning up loggers and visual display outputs.

@alxlyj alxlyj changed the base branch from main to robynpy_release December 6, 2024 22:53
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@alxlyj alxlyj marked this pull request as ready for review December 6, 2024 22:53
@alxlyj alxlyj requested a review from sumane81 December 6, 2024 22:53
sumane81
sumane81 reviewed Dec 6, 2024
View reviewed changes
sumane81
sumane81 reviewed Dec 6, 2024
View reviewed changes
sumane81
sumane81 reviewed Dec 6, 2024
View reviewed changes
@alxlyj alxlyj requested a review from sumane81 December 6, 2024 23:11
sumane81
sumane81 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@sumane81 sumane81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alxlyj alxlyj merged commit 14e6713 into robynpy_release Dec 6, 2024
2 checks passed
@alxlyj alxlyj deleted the cleanup/notebooks_loggers branch December 6, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumane81 sumane81 sumane81 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxlyj @sumane81 @facebook-github-bot