This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Adds robustness to the perf.sh method for finding hhvm pid. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, the newest pid returned from pgrep -xn hhvm is a child process of the parent hhvm process. In this case the perf-<pid>.map file is missing, so just subract one and use the parent process. Note: This process is not the instance of hhvm running perf.php.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the newest pid returned from pgrep -xn hhvm is a child
process of the parent hhvm process. In this case the perf-.map
file is missing, so just subract one and use the parent process.
Note: This process is not the instance of hhvm running perf.php.