This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Check for invalid arguments passed to perf.php #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oss-performance does not give any warnings when passing an incorrect argument. When a wrong argument is found, the "getopt" Hack function that parses arguments stops silently and the rest of the arguments are simply discarded without notice. This change fixes this verbosity issue by going through all the parameters passed to perf.php and checking if they are valid. If they are not, a warning is displayed saying which parameter is wrong and the "help" message is printed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oss-performance does not give any warnings when passing an incorrect argument. When a wrong argument is found, the "getopt" Hack function that parses arguments stops silently and the rest of the arguments are simply discarded without notice.
This PR fixes this verbosity issue by going through all the parameters passed to perf.php and checking if they are valid. If they are not, a warning is displayed saying which parameter is wrong and the "help" message is printed.