This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Add Memcached support for the MediaWiki target #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff adds support for Memcached. If a target supports Memcached, oss-performance will start it on 127.0.0.1:11888. The only target supporting Memcached right now is MediaWiki. For other targets to support Memcached, they must override PerfTarget::supportsMemcached(). This diff also sets $wgUseDatabaseMessages to false in the configuration file if Memcached is disabled, as recommended in the MediaWiki manual. For MediaWiki with Memcached enabled, observing a ~6% increase in RPS, a decrease in system idle time, as well as ~7 percentage points more cycles being spent in HHVM. Command line options added: --memcached: path to memcached binary --delay-memcached-startup: number of seconds to delay Memcached startup --memcached-port: TCP port to listen on (default is 11888) --no-memcached: don't use memcached (even if target supports it) --memcached-threads: number of memcached threads to spawn (default is 4 for machines with small number of cores, 32 otherwise)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds support for Memcached. If a target supports Memcached,
oss-performance will start it on 127.0.0.1:11888. The only target supporting
Memcached right now is MediaWiki. For other targets to support Memcached, they
must override PerfTarget::supportsMemcached().
This diff also sets $wgUseDatabaseMessages to false in the configuration file
if Memcached is disabled, as recommended in the MediaWiki manual.
For MediaWiki with Memcached enabled, observing a ~6% increase in RPS, a
decrease in system idle time, as well as ~7 percentage points more cycles being
spent in HHVM.
Command line options added:
--memcached: path to memcached binary
--delay-memcached-startup: number of seconds to delay Memcached startup
--memcached-port: TCP port to listen on (default is 11888)
--no-memcached: don't use memcached (even if target supports it)
--memcached-threads: number of memcached threads to spawn (default is 4 for
machines with small number of cores, 32 otherwise)