This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
updating oss-performance to work with recent changes to invariant sig… #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredemmott
suggested changes
Jan 31, 2017
There was a problem hiding this comment.
Instead of concatenating, use format patterns.
See comments on similar #77
|
Requested changes made |
fredemmott
suggested changes
Jan 31, 2017
| ' after '. | ||
| $options->maxdelayUnfreeze. | ||
| ' secs', | ||
| 'Failed to unfreeze %s after %s secs', |
|
Thanks! |
kevand900
pushed a commit
to kevand900/oss-performance
that referenced
this pull request
Mar 22, 2017
…mote machine to host the mysql database. This option is to be used with "--i-am-not-benchmarking". Changes were made in PerfOptions.php for the command line parsing, and DatabaseInstaller.php for installing the database. Drupal7, Mediawiki, and Wordpress are the targets which support this feature presently. For more info on how to run please see "Enabling_MySWL_Remote_Connection.txt". Resolving requested changes. Resolved requested changes. Added remote db support for all targets. Making $host local for cleanliness. updating oss-performance to work with recent changes to invariant sig… (facebookarchive#78) * updating oss-performance to work with recent changes to invariant signature * updating change to reflect comments * changing %s to %f for a numeric value Update siege blacklist to 3.0 Updated mediawiki to 1.28. Added setup script, php fpm support, modified batch run to be able to configure databases, fixed tc-print, and perf. Update fbcode option for use with buck. Add processor affinity setting "--cpu-fraction". Add no-jit option, and stat-cache option. Adding command line parameter to specify the number of HHVM Server Th… (facebookarchive#80) * Adding command line parameters to change the number of hhvm server threads as well as the benchmark concurrency. In order to use these options they must be paired with '--i-am-not-benchmarking' For HHVM Server Threads use: --hhvm-server-threads=<desiredNumber> The default is 100 For Benchmark Concurrency use: --benchmark-concurrency=<desiredNumber> The default is 200 * Adding command line parameter to specify the number of HHVM Server Threads as well as Benchmark Concurrency. These options are to be paired with '--i-am-not-benchmarking' For HHVM Server threads: --hhvm-server-threads=<number> Default is 100 For Benchmark Concurrency --benchmark-concurrency=<number> Default is 200 * Adding command line parameters to specify the number of ServerThreads (--server-threads=<NUM>) and the BenchmarkConcurrency (--benchmark-concurrency=<NUM>). Revising the method that these are set, using a setter method in PerfSettings.php for the BenchmarkConcurrency, set from PerfOptions.php. For ServerThreads we append the dhhvm.server.thread_count to the hhvmExtraArguments array. This is just a wrapper for the optional method of specifying via --hhvm-extra-arguments=-dhhvm.server.thread_count=<NUM>. * Made it so we do not have to use --i-am-not-benchmarking for --server-threads and --client-threads. * Resolved review comments. * Resolving requested changes. * Resolving requested changes, made pm.max_children variable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nature