Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Fixed check for gzcat (and made it quieter). #52

Merged
merged 2 commits into from
Sep 24, 2015

Conversation

gdbentley
Copy link
Contributor

No description provided.

@fredemmott
Copy link
Contributor

What platform? cc @jwatzman

I wouldn't be surprised if this check is non-portable

@gdbentley
Copy link
Contributor Author

It was failing for me on CentOS 7. I have a zcat but no gzcat. $cat ended up an empty string.

@jwatzman
Copy link
Contributor

The 2>/dev/null is fine, but can we make the if test just check for !$cat? It wouldn't surprise me if we got different results (null vs empty string) on different platforms.

@gdbentley
Copy link
Contributor Author

!$cat works for me.

fredemmott added a commit that referenced this pull request Sep 24, 2015
Fixed check for gzcat (and made it quieter).
@fredemmott fredemmott merged commit 94a39f0 into facebookarchive:master Sep 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants