This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Driver program needs to be updated for hack #89
Comments
sushmakt
added a commit
to sushmakt/oss-performance
that referenced
this issue
Jan 18, 2018
HHVM 3.24 requires the reference arguments to be marked at the call site, following which the current oss-performance code throws errors when "hh_client" is run or the workload is run using HHVM runtime. This patch fixes the issue by marking the reference arguments at the call time. However, this patch also mandates the HHVM version to be at least 3.24 and makes it incompatible with the earlier versions as the change is not supported in earlier versions of HHVM Fixes facebookarchive#89
fredemmott
pushed a commit
that referenced
this issue
Jan 30, 2018
HHVM 3.24 requires the reference arguments to be marked at the call site, following which the current oss-performance code throws errors when "hh_client" is run or the workload is run using HHVM runtime. This patch fixes the issue by marking the reference arguments at the call time. However, this patch also mandates the HHVM version to be at least 3.24 and makes it incompatible with the earlier versions as the change is not supported in earlier versions of HHVM Fixes #89
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
/mnt/cdn/hhvm/oss-performance$ /mnt/cdn/hhvm/play.011818a/hhvm/hphp/hhvm/hhvm perf.php --i-am-not-benchmarking --trace --mediawiki --hhvm=/mnt/cdn/hhvm/play.011818a/hhvm/hphp/hhvm/hhvm
Catchable fatal error: Hack type error: This argument should be annotated with & at /mnt/cdn/hhvm/oss-performance/base/DatabaseInstaller.php line 93
The text was updated successfully, but these errors were encountered: