Add pause to wait for end of warmup. Useful as retranslateAll can run…

… long. Also switched options passed to HHVM to be compatible with HHVM 3.0
facebookarchive · Apr 3, 2017 · fa84247 · octmoraru · Apr 4, 2017 · mofarrell
1 parent d4ac30f
commit fa84247
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/base/HHVMDaemon.php b/base/HHVMDaemon.php
@@ -62,6 +62,12 @@ protected function getTarget(): PerfTarget {
     return $this->target;
   }
 
+  <<__Override>>
+  public function needsRetranslatePause(): bool {
+    $status = $this->adminRequest('/warmup-status');
+    return $status !== '' && $status !== 'failure';
+  }
+
   <<__Override>>
   protected function getArguments(): Vector<string> {
     if ($this->options->cpuBind) {
@@ -82,10 +88,10 @@ protected function getArguments(): Vector<string> {
       'Server.ErrorDocument404=index.php',
       '-v',
       'Server.SourceRoot='.$this->target->getSourceRoot(),
-      '-d',
-      'hhvm.log.file='.$this->options->tempDir.'/hhvm_error.log',
-      '-d',
-      'pid='.escapeshellarg($this->getPidFilePath()),
+      '-v',
+      'Log.File='.$this->options->tempDir.'/hhvm_error.log',
+      '-v',
+      'PidFile='.escapeshellarg($this->getPidFilePath()),
       '-c',
       OSS_PERFORMANCE_ROOT.'/conf/php.ini',
     };

diff --git a/base/PHPEngine.php b/base/PHPEngine.php
@@ -12,4 +12,6 @@
 abstract class PHPEngine extends Process {
   public abstract function __toString(): string;
   public function writeStats(): void {}
+
+  public function needsRetranslatePause(): bool { return false; }
 }
diff --git a/base/PerfRunner.php b/base/PerfRunner.php
@@ -152,6 +152,11 @@ private static function RunWithOptionsAndEngine(
       exec($options->scriptAfterWarmup);
     }
 
+    while ($php_engine->needsRetranslatePause()) {
+      self::PrintProgress('Pausing 5 seconds to allow retranslation threads to catch up.');
+      sleep(5);
+    }
+
     self::PrintProgress('Starting Siege for benchmark');
     $siege = new Siege($options, $target, RequestModes::BENCHMARK);
     $siege->start();