Enable filecache by default

facebookarchive · Jun 4, 2015 · ca832c5 · ca832c5
1 parent 0af3fff
commit ca832c5
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/base/PerfOptions.php b/base/PerfOptions.php
@@ -122,7 +122,7 @@ public function __construct(Vector<string> $argv) {
 
       'no-proxygen',
       'no-repo-auth',
-      'file-cache',
+      'no-file-cache',
       'pcre-cache:',
       'pcre-cache-expire:',
       'pcre-cache-size:',
@@ -236,7 +236,7 @@ public function __construct(Vector<string> $argv) {
     $this->applyPatches = $this->getBool('apply-patches');
 
     $this->precompile  = !$this->getBool('no-repo-auth');
-    $this->filecache = $this->getBool('file-cache');
+    $this->filecache = $this->precompile && !$this->getBool('no-file-cache');
     $this->pcreCache = $this->getNullableString('pcre-cache');
     $this->pcreSize = $this->getNullableInt('pcre-cache-size');
     $this->pcreExpire = $this->getNullableInt('pcre-cache-expire');
@@ -313,6 +313,7 @@ public function validate() {
     if ($this->php5) {
       $this->precompile = false;
       $this->proxygen = false;
+      $this->filecache = false;
     }
     if ($this->notBenchmarkingArgs && !$this->notBenchmarking) {
       $message = sprintf(
@@ -365,13 +366,6 @@ public function validate() {
       );
     }
 
-    if ($this->filecache) {
-      invariant(
-        $this->precompile,
-        'The file cache must be used with --repo-auth'
-      );
-    }
-
     if ($this->pcreCache !== null || $this->pcreSize || $this->pcreExpire) {
       invariant(
         $this->hhvm !== null,