add wait for message queue to drain before final siege (#88)

facebookarchive · Oct 10, 2017 · aa38192 · aa38192
1 parent e783511
commit aa38192
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/base/HHVMDaemon.php b/base/HHVMDaemon.php
@@ -68,6 +68,15 @@ public function needsRetranslatePause(): bool {
     return $status !== '' && $status !== 'failure';
   }
 
+  <<__Override>>
+  public function queueEmpty(): bool {
+    $status = $this->adminRequest('/check-queued');
+    if ($status === 'failure') {
+      return true;
+    }
+    return $status !== '' && $status === '0';
+  }
+
   <<__Override>>
   protected function getArguments(): Vector<string> {
     if ($this->options->cpuBind) {

diff --git a/base/PHPEngine.php b/base/PHPEngine.php
@@ -14,4 +14,5 @@ public abstract function __toString(): string;
   public function writeStats(): void {}
 
   public function needsRetranslatePause(): bool { return false; }
+  public function queueEmpty(): bool { return true; }
 }
diff --git a/base/PerfRunner.php b/base/PerfRunner.php
@@ -155,6 +155,12 @@ private static function RunWithOptionsAndEngine(
       );
     }
 
+    self::PrintProgress('Server warmed, checking queue status.');
+    while (!$options->skipWarmUp && !$php_engine->queueEmpty()) {
+      self::PrintProgress('Server warmed, waiting for queue to drain.');
+      sleep(10);
+    }
+
     self::PrintProgress('Clearing nginx access.log');
     $nginx->clearAccessLog();