Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Commit

Permalink
Make proxygen and repo-auth the defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
@fredemmott
fredemmott committed Jun 3, 2015
1 parent 786c2d2 commit 5355d7d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions base/PerfOptions.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ public function __construct(Vector<string> $argv) {

'wait-at-end',

'proxygen',
'repo-auth',
'no-proxygen',
'no-repo-auth',
'file-cache',
'pcre-cache:',
'pcre-cache-expire:',
Expand Down Expand Up @@ -232,10 +232,10 @@ public function __construct(Vector<string> $argv) {
$this->skipDatabaseInstall = $this->getBool('skip-database-install');
$this->noTimeLimit = $this->getBool('no-time-limit');
$this->waitAtEnd = $this->getBool('wait-at-end');
$this->proxygen = $this->getBool('proxygen');
$this->proxygen = $this->hhvm && !$this->getBool('no-proxygen');
$this->applyPatches = $this->getBool('apply-patches');

$this->precompile = $this->getBool('repo-auth');
$this->precompile = $this->hhvm && !$this->getBool('no-repo-auth');
$this->filecache = $this->getBool('file-cache');
$this->pcreCache = $this->getNullableString('pcre-cache');
$this->pcreSize = $this->getNullableInt('pcre-cache-size');
Expand Down

1 comment on commit 5355d7d

@Kazanir
Copy link
Contributor

@Kazanir Kazanir commented on 5355d7d Jun 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped this to Fred on IRC but in case he doesn't see it: this doesn't work when running in batch mode. The hhvm arg is handled elsewhere in batch-run.php and not passed into $argv or available in getopt() at this point. So proxygen and precompile end up un-overrideably FALSE with this change. Oops.

Please sign in to comment.