Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Add Reference to IMAGE_DIFF_DIR to ReadMe #201

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

pres
Copy link
Contributor

@pres pres commented Nov 5, 2016

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.


Define the `IMAGE_DIFF_DIR` to the directory where you want to store diffs of failed snapshots.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this few lines above and mark as point 3. Additional info about optional nature of this macro (and maybe default value) would be helpful.

@nscoding
Copy link
Contributor

nscoding commented Nov 7, 2016

thank you for this, can you sign the License Agreement so I can merge this PR?

@pres
Copy link
Contributor Author

pres commented Nov 9, 2016

  • CLA

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nscoding nscoding merged commit 07d70ea into facebookarchive:master Nov 11, 2016
thorthugnasty pushed a commit to thorthugnasty/ios-snapshot-test-case that referenced this pull request Jan 26, 2017
…t-case into andrewli/add-color-tolerance

* 'master' of https://github.com/facebook/ios-snapshot-test-case:
  Fix documentation warnings (facebookarchive#205)
  Add Reference to IMAGE_DIFF_DIR (facebookarchive#201)
  Update pod version and change log (facebookarchive#199)
  Bump version to 2.1.4 (facebookarchive#198)
  Replace big macro with Objective-C method for easier debugging. (facebookarchive#180)
  Merge Swift 3 in master (facebookarchive#194)
  Fix pod verification (facebookarchive#193)
  Bump version to 2.3 (facebookarchive#192)
  Revert "Merge Swift 3 into master" (facebookarchive#191)
  Merge Swift 3 into master (facebookarchive#189)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants