Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Rename ApplicationDelegate to SDKApplicationDelegate to avoid name clashes. #36

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

nlutsenko
Copy link
Contributor

Preventing name clashes, as ApplicationDelegate is likely to exist in the app module.

Closes #35

@ghost ghost added GH Review: review-needed CLA Signed The Facebook CLA has been signed labels Aug 3, 2016
@nlutsenko nlutsenko added this to the 0.2.0 milestone Aug 3, 2016
@1dotd4
Copy link

1dotd4 commented Aug 3, 2016

Wait why not FBApplicationDelegate?
SDKApplicationDelegate is too ambiguous

@nlutsenko
Copy link
Contributor Author

nlutsenko commented Aug 3, 2016

We already have SDKSettings and SDKVersion.
Biggest reason - Swifty names :)
The full name for SDKApplicationDelegate is FacebookCore.SDKApplicationDelegate, and since FacebookCore.FBApplicationDelegate would be too much of FB/Facebook in the name - we stick to SDKApplicationDelegate/SDKSettings.

@nlutsenko
Copy link
Contributor Author

This is a good point, and we might want to revisit this naming later, while we are still in beta.

@richardjrossiii
Copy link
Contributor

Agree with returning to naming in the future. If we had proper submodules, I would say we have Facebook.ApplicationDelegate, with Facebook.Login and Facebook.Share as other modules. But alas, that's currently not possible.

@nlutsenko nlutsenko merged commit 1fa8368 into master Aug 8, 2016
@nlutsenko nlutsenko deleted the nlutsenko.appdelegate branch August 8, 2016 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed The Facebook CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants