This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
gemm: fp16 tensorcore fixes #1211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algo and compute type must match - you can't try to use CUBLAS_GEMM_DFALT without also calling cublasSetMathMode(..., CUBLAS_TENSOR_OP_MATH).
The change is very small if you ignore whitespace changes
|
This one is over one month old, is it still relevant? |
|
Yes. I'm surprised nobody has complained about these issues yet. Presumably y'all don't run any tensorcore tests on non-Volta hardware. |
There was a problem hiding this comment.
@akyrola has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Ok, processing it. Thanks! |
|
Thank you for your contribution! PyTorch and Caffe2 are now officially merged with the PyTorch 1.0 preview release. Please submit on https://github.com/pytorch/pytorch if this is still an issue over there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.