Skip to content

Conversation

BoBoDai
Copy link

@BoBoDai BoBoDai commented Sep 10, 2025

This pr resolved #4471 .

Add RISCV-V implementation from xxhash repo.

Relevant performance tests are reflected in xxHash pr #1070 and #1066

I conducted testing by replacing the hash function in the fuzzer and conduct testing through qemu.

thread pool tests OK
1085 fuzzer tests completed

Although zstd does not currently use xxh3, this will better support teams who wish to use zstd and xxh3 on RISCV devices.

Copy link

meta-cla bot commented Sep 10, 2025

Hi @BoBoDai!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

meta-cla bot commented Sep 10, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Sep 10, 2025
@BoBoDai BoBoDai changed the title Add xxh3 riscv-v implementation from xxhash repo. Add xxh3 RISCV-V implementation from xxhash repo. Sep 10, 2025
@BoBoDai
Copy link
Author

BoBoDai commented Sep 11, 2025

Hi, @Cyan4973 i copy the rvv xxh3 code from xxHash repo, and through fuzzer tests by qemu.
if you could take a look when you have a moment.
Thanks :)

@Cyan4973
Copy link
Contributor

This looks correct,
though also, as you noted,
it's not really useful, since zstd doesn't employ xxh3 anywhere.

(in fact, we even disable it explicitly to ensure it does not occupy binary space).

@BoBoDai
Copy link
Author

BoBoDai commented Sep 12, 2025

Yes, I conducted the xxh3 fuzzer test by deleting this line.
In fact, repo like zstd-jni can provide Java with .so files that are quick and easy to use, which also relies on the zstd.
This undoubtedly provides an additional option for those who wish to use xxh3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RISC-V Vector (RVV) Support for XXH3

2 participants