Skip to content

Conversation

Cyan4973
Copy link
Contributor

to Github Actions CI

to Github Actions CI
write the recipe directly in the .yml file

For some reason, SolarisOS is not considered posix by the Makefile (?)
@Cyan4973
Copy link
Contributor Author

One issue with the cmake recipe is that it requires the CXX compiler to compile zstd.
This is incorrect. zstd itself doesn't require CXX, only C. This is a problem for systems which can provide a C compiler but not a C++ one, since the cmake recipe will fail them.
It also seems this over-reach has been used and depended upon in some parts of the complex multi-files cmake recipe. Consequently, removing CXX from the zstd project creates errors in some environments,
cmake + visual being one of them.
I guess fixing this is a preliminary step in order to allow Solaris VM as a test.

@Cyan4973 Cyan4973 marked this pull request as draft January 29, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants