Make idiomatic cmake install so third party cmake installers work right. #1924
Conversation
|
Hi ned14! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| @@ -127,6 +127,7 @@ if (ZSTD_BUILD_STATIC) | |||
| set_target_properties( | |||
| libzstd_static | |||
| PROPERTIES | |||
| POSITION_INDEPENDENT_CODE On | |||
There was a problem hiding this comment.
You may wish a separate target for this. It's a tricky one, it's not uncommon that static libraries get linked into dynamic libraries, however sometimes fPIC does slightly damage performance.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks @ned14 ! Looks good to me ! |
Please see issue #1922