-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with c++14/17 fails on clang #3250
Comments
MaskRay
added a commit
to MaskRay/zstd
that referenced
this issue
Sep 22, 2022
Clang doesn't allow [[deprecated(...)]] attribute after __attribute__. Move [[deprecated(...)]] before __attribute__ to fix C++14/C++17 uses with Clang. Fix facebook#3250
MaskRay
added a commit
to MaskRay/zstd
that referenced
this issue
Sep 22, 2022
Clang doesn't allow [[deprecated(...)]] attribute after __attribute__. Move [[deprecated(...)]] before __attribute__ to fix C++14/C++17 uses with Clang. Fix facebook#3250
MaskRay
added a commit
to MaskRay/zstd
that referenced
this issue
Sep 22, 2022
Clang doesn't allow [[deprecated(...)]] attribute after __attribute__. Move [[deprecated(...)]] before __attribute__ to fix C++14/C++17 uses with Clang. Fix facebook#3250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When building with C++17, zstd fails
I believe it came from
https://github.com/facebook/zstd/pull/3225/files
where before it was
And after it became in reverse order
I see that the order is slightly inconsistent throughout the file, for example in c450f9f the order of ZSTD_DEPRECATED/ZSTDLIB_API in reversed
To Reproduce
Expected behavior
Builds
Screenshots and charts
If applicable, add screenshots and charts to help explain your problem.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: