Add fb_native_wrapper.bzl to fix Travis CI #843
Conversation
|
Thank you so much! Trying this out right now. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
we have some internal hiccups around this file – I will have to do some work, but we will merge it. |
|
Thanks for the feedback, let me know if there is anything I can do to help you :) |
|
Thank you!. Nothing you can do – shipit was configured a bit too strictly. I am waiting for a re-deploy now, and then we should be able to get this one in. |
Summary: Github and fbsource got out of sync, we have a PR to fix this: #843 This updates the internal-only file to match the PR, so that we can merge it without hassle. Reviewed By: cuva Differential Revision: D13879526 fbshipit-source-id: f83115617e580e118a5f4e0f37e877db38a8fcac
Summary: Github and fbsource got out of sync, we have a PR to fix this: facebook/yoga#843 This updates the internal-only file to match the PR, so that we can merge it without hassle. Reviewed By: cuva Differential Revision: D13879526 fbshipit-source-id: f83115617e580e118a5f4e0f37e877db38a8fcac
Summary: Github and fbsource got out of sync, we have a PR to fix this: facebook/yoga#843 This updates the internal-only file to match the PR, so that we can merge it without hassle. Reviewed By: cuva Differential Revision: D13879526 fbshipit-source-id: f83115617e580e118a5f4e0f37e877db38a8fcac
3 participants
When I was implementing #842, I noticed that CI was failing, but it did not seem to be caused by my changes. As you can see in the build log (https://travis-ci.org/facebook/yoga/jobs/473825507#L1217), the build depends on a build script that is not in the repository. In d02f4a9, @scottrice changed the build scripts to depend on
fb_native_wrapper.bzlwithout introducing that file into the repository.In this PR, I've introduced the bzl file, copied from the react-native project. Since it appears to only be a wrapper at this point, I'm assuming that this is the correct approach.