Skip to content

Conversation

@lukasredev
Copy link
Contributor

…outNode, when the node has no children.

I'am currently working on a new implementation of the TextView element in react-native.
My implementation uses the node->measure function to calculate the height of the element, but a TextView may also have subviews. If thats the case it's necessary to execute the rest of the layoutNode function and not stopping it after line 318.
This change does not affect the behaviour of the other module ( RCText ), that uses the measure function, because this element will always have a children_count of zero.

@vjeux
Copy link
Contributor

vjeux commented May 8, 2015

Can you run make in order to generate the C and Java versions as well?

I have a feeling that what you are working on is going to be glorious! Are you going to let you embed or arbitrary elements inside of a text node? If yes, <3<3<3

@lukasredev
Copy link
Contributor Author

@vjeux I have created another pull request.

@lukasredev lukasredev closed this May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants