Make Yoga thread safe #786
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ref: #769
Problem
gNodeInstanceCount,gConfigInstanceCount,gCurrentGenerationCount,gDepthare global variables inYoga.cpp. They are not safe when using multithreading.My idea
atomicforgNodeInstanceCountandgConfigInstanceCountbecause of counting instances only.gCurrentGenerationCountandgDepthin root node for multithreading.My solution
gNodeInstanceCountandgConfigInstanceCountgCurrentGenerationCountandgDepthare stored inYGNode.