Fix text node rounding with fractional dimensions matching the rounding factor #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Thank you |
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 4, 2017
…ng factor Summary: If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction. Fixes facebook/yoga#580. Closes facebook/yoga#583 Reviewed By: marco-cova Differential Revision: D5274212 Pulled By: emilsjolander fbshipit-source-id: 1febf9194210437ab77f91319d10d4da9b284b79
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jul 4, 2017
…ng factor Summary: If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction. Fixes facebook/yoga#580. Closes facebook/yoga#583 Reviewed By: marco-cova Differential Revision: D5274212 Pulled By: emilsjolander fbshipit-source-id: 1febf9194210437ab77f91319d10d4da9b284b79
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
…ng factor Summary: If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction. Fixes facebook/yoga#580. Closes facebook/yoga#583 Reviewed By: marco-cova Differential Revision: D5274212 Pulled By: emilsjolander fbshipit-source-id: 1febf9194210437ab77f91319d10d4da9b284b79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction.
Fixes #580.