Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sumcheck IOP for LogUp-GKR #295
Sumcheck IOP for LogUp-GKR #295
Changes from 14 commits
8ac25c7
5e06378
16389d6
380aa1a
7a1a99e
1901066
8a57216
ff9e6fa
7e24f8f
23044e8
ad0497d
d721bc2
2e5a704
06454d9
2c07857
2e02f1f
e7a50c0
2b64dbf
ea7cb84
dae27e6
9543e1a
60c8591
7338caf
43c7441
f85e44f
be0c2cd
1847d0d
3adc855
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a docstring here? This trait does a lot of things and it's a little bit hard to get a handle on exactly what
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would rename this to
logup_randomness