Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstration: fixes the pywatchman build script and documents how to publish an updated version to pypi #1074

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Demonstration: fixes the pywatchman build script and documents how to publish an updated version to pypi #1074

wants to merge 3 commits into from

Commits on Nov 21, 2022

  1. Fix the build directory path for pywatchman 

    The default src directory in the setup script was missing a relative
parent traversal, making it impossible to build without setting the
environment variable CMAKE_CURRENT_SOURCE_DIR.

This change fixes the relative path allowing the build to proceed.
    @jarshwah
    jarshwah committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a36e2cd View commit details
    Browse the repository at this point in the history

  2. Update the setup to publish an unofficial version to pypi 

    An unofficial build will be published to pypi given there hasn't been
an official release since 2017.

pywatchman is a dependency for Django projects and is no longer able
to run with recent versions of watchman.

This is a temporary unofficial release meant to unblock those depending
on pywatchman that are unable to use it. Hopefully this spurs Facebook
into publishing a new version.
    @jarshwah
    jarshwah committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    c34c691 View commit details
    Browse the repository at this point in the history

  3. Document the build instructions for publishing to pypi 

    The notes in `setup.py` for building and publishing the package are
not complete, as cibuildwheel requires a little bit of it's own setup,
but the instructions are a decent guide to getting it done if someone
wants to replicate their build.
    @jarshwah
    jarshwah committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    9112f33 View commit details
    Browse the repository at this point in the history