Skip to content

Migrate GitHub Actions off deprecated Node.js 20 #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leoleovich wants to merge 2 commits into from
Closed

Migrate GitHub Actions off deprecated Node.js 20 #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef6fa6
Use SWRX timestamps in server tests to match production (#532)
leoleovich Jun 4, 2026
8a020da
Migrate GitHub Actions off deprecated Node.js 20
leoleovich Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cifuzz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ jobs:
fuzz-seconds: 300
output-sarif: true
- name: Upload Crash
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
if: failure() && steps.build.outcome == 'success'
with:
name: artifacts
path: ./out/artifacts
- name: Upload Sarif
if: always() && steps.build.outcome == 'success'
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3
with:
# Path to SARIF file relative to the root of the repository
sarif_file: cifuzz-sarif/results.sarif
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
- uses: actions/checkout@v5
- uses: actions/setup-go@v6
with:
go-version: 1.25
- run: sudo apt-get install libpcap-dev
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
- uses: actions/checkout@v5
- uses: actions/setup-go@v6
with:
go-version: 1.25
- run: sudo apt-get install libpcap-dev libcap2-bin
Expand All @@ -17,6 +17,6 @@ jobs:
- name: Run coverage
run: sudo --preserve-env=PATH capsh --inh=cap_net_raw --print -- -c "go test -v -race -coverprofile=coverage.txt -covermode=atomic ./..."
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
4 changes: 2 additions & 2 deletions ntp/responder/server/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func TestListener(t *testing.T) {
ExpectedListeners: 1,
ExpectedWorkers: 0,
},
Config: Config{Workers: 42, TimestampType: timestamp.SW, Iface: "lo"},
Config: Config{Workers: 42, TimestampType: timestamp.SWRX, Iface: "lo"},
}
conn := tryListenUDP(t)
defer conn.Close()
Expand Down Expand Up @@ -172,7 +172,7 @@ func TestServer(t *testing.T) {
},
Stats: &stats.JSONStats{},
tasks: make(chan task, workers),
Config: Config{Workers: workers, TimestampType: timestamp.SW, Iface: "lo"},
Config: Config{Workers: workers, TimestampType: timestamp.SWRX, Iface: "lo"},
}
// create workers
for range workers {
Expand Down
Loading