Fix track_symlinks reference in taste-tester impact #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@track_symlinks is set for TasteTester::Client, but not for TasteTester::Commands so this reference is always interpreted as false. The impact of this is that taste-tester impact is unable to detect changed files that are symlinked into the TasteTester::Config.relative_cookbook_dirs.
Since we are already referencing other config options within this function we can just read TasteTester::Config.track_symlinks directly.
Tested locally and verified that when track_symlinks is specified as true in the config, taste-tester impact adds the files to the returned changeset