Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.rb #180

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Update client.rb #180

merged 1 commit into from
Oct 22, 2021

Conversation

steelcowboy
Copy link
Contributor

See #179. This should be data_bags per https://github.com/chef/chef/blob/61a11902ab814aad3625eb4da7e3345d63ee7c09/knife/lib/chef/knife/data_bag_from_file.rb#L64

To repro:

  1. Set up taste-tester to use the bundle option
  2. Set up a client with a runlist containing databags to work with the local bundle
  3. Observe that you get a 404.
  4. Set data_bag_path "#{taste_tester_dest}/databag" in the client config and observe it now works

To test this change:

  1. Create this change locally: sed -i "s#'databag'#'data_bags'#" /path/to/taste_tester/lib/taste_tester/client.rb
  2. Upload a new bundle. Remove the data_bag_path override
  3. Observe Chef in local mode now works

@scottruss scottruss merged commit 11f7c61 into facebook:main Oct 22, 2021
@jaymzh
Copy link
Collaborator

jaymzh commented Oct 22, 2021

post-factro approval.

As to the bug, bundle-mode was written for the internal CI stuff that leverages taste-tester for prod, and of course prod at FB doesn't use databags, so it's not surprising this happened. Thanks for fixing it Jim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants