Merge pull request #185 from dafyddcrosby/ruby_ci_24

[github] drop Ruby 2.4 from CI, add 2.7
facebook · Aug 18, 2023 · d324d16 · d324d16
2 parents 677691a + 0fb8f23
commit d324d16
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.4, 2.5, 2.6]
+        ruby: [2.5, 2.6, 2.7]
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repository

diff --git a/bin/taste-tester b/bin/taste-tester
@@ -245,12 +245,12 @@ MODES:
       ' Anything parsable is ok, such as "5/18 4:35" or "16/9/13".'
     ) do |time|
       # can make this an implicit rescue after we drop ruby 2.4
-      begin
-        options[:testing_until] = Time.parse(time)
-      rescue StandardError
-        logger.error("Invalid date: #{time}")
-        exit 1
-      end
+
+      options[:testing_until] = Time.parse(time)
+    rescue StandardError
+      logger.error("Invalid date: #{time}")
+      exit 1
+
     end
 
     opts.on(

diff --git a/lib/taste_tester/exceptions.rb b/lib/taste_tester/exceptions.rb
@@ -18,10 +18,13 @@ module TasteTester
   module Exceptions
     class SshError < StandardError
     end
+
     class LocalLinkError < StandardError
     end
+
     class NoOpError < StandardError
     end
+
     class AlreadyTestingError < StandardError
       attr_reader :username