Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Markdown in commit template #574

Closed
wants to merge 3 commits into from
Closed

Use Markdown in commit template #574

wants to merge 3 commits into from

Conversation

steveluscher
Copy link
Contributor

Commit message template in editor:

image

Rendering in GitHub PR:

image

Addresses #569.

@fanzeyi
Copy link
Member

fanzeyi commented Mar 29, 2023

Pass by comment:

I think this is going to be tricky since we have tons of automation running internally using Summary: and Test Plan: as a marker.

This PR is still reasonable though. I think we might want to consider shipping a different default for open source.

@quark-zju
Copy link
Contributor

quark-zju commented Mar 29, 2023

How do you think about just leaving emptymsg empty? The "Summary" and "Test Plan" are Phabricator-ism that might not make sense everywhere, and the "<replace ...>" text seems to require extra key presses to delete it.

@steveluscher steveluscher closed this by deleting the head repository Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants