-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISL: gh: Field 'mergeQueueEntry' doesn't exist on type 'PullRequest' #906
Comments
I’m seeing this as well. |
+1 I am seeing in on GHE3.7 and 3.9. Could we please have a workaround if not able to upgrading GHE version? |
I'm also seeing this, and it's not possible for me to upgrade GHE. |
Same issue as #830. I can try and contribute a fix for this |
Summary: facebook#830 and facebook#906 reported sapling not working for old Github Enterprise versions since their graphql schema doesnt include merge queue. This adds a query to detect if merge queue is supported in the graphql version. Then, it will issue a different "YourPullRequestsQuery" depending on if merge queue is supported. I considered a few other approaches: - Just detect the error message and retry without merge queue field - a little gross to extract from the error - Use "@include" instead of an entirely separate query - didn't seem to count as a valid query still via graphiql at least (unsure if the query client here would strip out the unused field though) Test Plan: Haven't had a chance to test yet, will try and validate that both versions work and that the detection logic works.
Summary: Fix handling of GHE without merge queue support #830 and #906 reported sapling not working for old Github Enterprise versions since their graphql schema doesnt include merge queue. This adds a query to detect if merge queue is supported in the graphql version. Then, it will issue a different "YourPullRequestsQuery" depending on if merge queue is supported. I considered a few other approaches: - Just detect the error message and retry without merge queue field - a little gross to extract from the error - Use "include" instead of an entirely separate query - didn't seem to count as a valid query still via graphiql at least (unsure if the query client here would strip out the unused field though) Pull Request resolved: #926 Test Plan: Haven't had a chance to test yet, will try and validate that both versions work and that the detection logic works. Reviewed By: evangrayk Differential Revision: D60215245 fbshipit-source-id: cb36a77fbe0665353740d7fa97bc21ee9c86e0e8
The attached PR is now in sapling-scm VS Code extension version 0.1.54 release, please let me know if this fix works for folks using GHE affected by this! |
I'm seeing the error gh: Field 'mergeQueueEntry' doesn't exist on type 'PullRequest' when viewing ISL.
I think this is because my enterprise GH version (3.10) doesn't support this field, as it looks to be introduced in 3.12. I saw similar issues filed to the GH pull requests extension, and they worked around it somehow -- I'm guessing by using different/legacy query fields.
The text was updated successfully, but these errors were encountered: